Fix output_type=BF16 test_backward_adagrad_large_dims test#151
Open
avbokovoy wants to merge 1 commit intoabokovoi/upstreamfrom
Open
Fix output_type=BF16 test_backward_adagrad_large_dims test#151avbokovoy wants to merge 1 commit intoabokovoi/upstreamfrom
avbokovoy wants to merge 1 commit intoabokovoi/upstreamfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently,
vec4acc.cuhstores don't account forbf16outputs, treating them as FP16 during conversion from FP32. That makestest_backward_adagrad_large_dimstest to fail in some specific cases when D>1024 (or D>256 in the context of unit-test parameters) andforward_v2kernel is called. The way to reproduce the failure is to add@reproduce_failure('6.151.9', b'AEEAAEEAQQFCAQFBAUEDQQFBAQAAAAAAQQBBAg==')decorator totest_backward_adagrad_large_dimstest and run on current main branch.