Implement pre-sorting, caching and contigous warp processing in group_index_select#144
Open
avbokovoy wants to merge 8 commits intoabokovoi/upstreamfrom
Open
Implement pre-sorting, caching and contigous warp processing in group_index_select#144avbokovoy wants to merge 8 commits intoabokovoi/upstreamfrom
avbokovoy wants to merge 8 commits intoabokovoi/upstreamfrom
Conversation
aryaman-gupta
requested changes
Mar 5, 2026
aryaman-gupta
left a comment
aryaman-gupta
left a comment
There was a problem hiding this comment.
The PR introduces crucial optimizations for the group_index_select_or_add_2d_kernel. The majority of the code is clean and the separation of ROCm and CUDA codepaths has been done well.
Most of these changes were already reviewed in #139 . I have left a few comments that I think should be looked at before merging. Some of these are design choices, and the PR could proceed with merging even if the code is not modified,
…_index_select kernel
…h AutogradContext
avbokovoy
force-pushed
the
abokovoi/group-index-sort-and-cache-opt
branch
from
3754ab4 to
1248c83
Compare
aryaman-gupta
approved these changes
Mar 11, 2026
aryaman-gupta
left a comment
aryaman-gupta
left a comment
There was a problem hiding this comment.
The points raised in #144 (review) have been addressed and the PR is ready for merging
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up of #139
The differences are:
#ifdef USE_ROCMusage in favor ofif constexpr (OPT_BOOL).