Preserve repo-relative Windows scenario paths#12
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
Adjusts scenario-path sanitization to preserve repo-relative paths on Windows while still redacting truly external Windows/UNC paths in public-safe reports.
Changes:
- Prioritize repo-relative detection in
public_path()before applying Windows drive/UNC redaction. - Add regression test ensuring Windows-style paths under
ROOTstay repo-relative in reports.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| scripts/strix_scenario_contract.py | Reorders public_path() logic so in-repo Windows paths remain repo-relative before external redaction logic runs. |
| python/tests/test_strix_scenario_contract.py | Adds coverage asserting repo-relative behavior for Windows-style paths when ROOT is Windows-flavored. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This follow-up addresses the PR #11 Copilot/Codex review finding.\n\nChanges:\n- keep in-repo scenario paths repo-relative before applying Windows external-path redaction\n- retain external Windows/UNC redaction for public-safe reports\n- add regression coverage for Windows-style repo-relative paths\n\nValidation:\n- python scripts/verify_public_surface.py -> passed\n- pytest -q python/tests/test_strix_scenario_contract.py -> 11 passed\n- pytest -q -> 142 passed\n- cargo test -p strix-optimizer doctrine_profile_accepts_neutral_aliases --lib -> passed\n- cargo check -p strix-python -> passed