Skip to content

Mark funtions returning Result as #[must_use] #13

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
RLado merged 1 commit into from
Mar 29, 2025
Merged

Mark funtions returning Result as #[must_use] #13

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -274,6 +274,7 @@ pub fn add<T: Numeric<T>>(a: &Sprs<T>, b: &Sprs<T>, alpha: T, beta: T) -> Sprs<T
///
/// See: `schol(...)`
///
#[must_use]
pub fn chol<T: Numeric<T>>(a: &Sprs<T>, s: &mut Symb) -> Result<Nmrc<T>, Error> {
let mut top;
let mut d;
Expand Down Expand Up @@ -372,6 +373,7 @@ pub fn chol<T: Numeric<T>>(a: &Sprs<T>, s: &mut Symb) -> Result<Nmrc<T>, Error>
/// println!("{:?}", &b);
/// ```
///
#[must_use]
pub fn cholsol<T: Numeric<T>>(a: &Sprs<T>, b: &mut [T], order: i8) -> Result<(), Error> {
let n = a.n;
let mut s = schol(a, order); // ordering and symbolic analysis
Expand Down Expand Up @@ -513,6 +515,7 @@ pub fn ltsolve<T: Numeric<T>>(l: &Sprs<T>, x: &mut [T]) {
///
/// See: `sqr(...)`
///
#[must_use]
pub fn lu<T: Numeric<T>>(a: &Sprs<T>, s: &mut Symb, tol: T) -> Result<Nmrc<T>, Error> {
let n = a.n;
let mut col;
Expand Down Expand Up @@ -665,6 +668,7 @@ pub fn lu<T: Numeric<T>>(a: &Sprs<T>, s: &mut Symb, tol: T) -> Result<Nmrc<T>, E
/// ```

///
#[must_use]
pub fn lusol<T: Numeric<T>>(a: &Sprs<T>, b: &mut [T], order: i8, tol: T) -> Result<(), Error> {
let mut x = vec![T::zero(); a.n];
let mut s;
Expand Down