Add RL-Kernel linear_logp integration with TP2 benchmark config#2
Draft
inaniloquentee wants to merge 4 commits into
Draft
Add RL-Kernel linear_logp integration with TP2 benchmark config#2inaniloquentee wants to merge 4 commits into
inaniloquentee wants to merge 4 commits into
Conversation
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Signed-off-by: inaniloquentee <3051000145@qq.com>
Signed-off-by: inaniloquentee <3051000145@qq.com>
Signed-off-by: inaniloquentee <3051000145@qq.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
linear_logpintegration and TP-aware tests for the vime benchmark path.linear_logpcalls: call count, token count, dispatch elapsed, and tokens-per-call totals/deltas.scripts/run-qwen3-30B-A3B.shdefault to a non-smoke 2xH100 performance pre-gate config fromvime-RLK.md.experiments/artifacts and result files from this PR.2xH100 config
NUM_GPUS=2,MEGATRON_TP=2,MEGATRON_EP=2,MEGATRON_CP=1.ROLLOUT_NUM_GPUS_PER_ENGINE=2,VLLM_GPU_MEMORY_UTILIZATION=0.50.NUM_ROLLOUT=24,ROLLOUT_BATCH_SIZE=2,N_SAMPLES_PER_PROMPT=2,GLOBAL_BATCH_SIZE=4,MAX_TOKENS_PER_GPU=4096,ROLLOUT_MAX_RESPONSE_LEN=1024.NUM_GPUS.Runtime counters
train/rl_kernel_linear_logp_call_count_total|delta.train/rl_kernel_linear_logp_token_count_total|delta.train/rl_kernel_linear_logp_dispatch_elapsed_s_total|delta.train/rl_kernel_linear_logp_tokens_per_call_total|delta.Acceptance
VIME_RL_KERNEL=1,VIME_RL_KERNEL_OPS=linear_logp,VIME_RL_KERNEL_STRICT=1.rl_kernel_fallback_count = 0, positivelinear_logpcall/token deltas, and finite logprob/loss/reward metrics.Tests
bash -n scripts/run-qwen3-30B-A3B.sh— passed.git diff --check— passed.PYTHONPATH=. pytest tests/test_rl_kernel_args.py tests/test_rl_kernel_linear_logp_integration.py tests/test_rl_kernel_logp_integration.py tests/test_metric_report.py tests/test_value_temperature.py -q— 47 passed, 1 warning.pre-commit run --files scripts/run-qwen3-30B-A3B.sh vime-RLK.md vime/backends/megatron_utils/rl_kernel.py vime/backends/megatron_utils/model.py tests/test_rl_kernel_linear_logp_integration.py— passed.