Button outlines (#325) #326
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change is to remedy the issue in the previous commit where the focused outline color (which was white) of the proposal submission buttons would blend in with the page background.
Created a class for the outline stylization used on the developer menu buttons for clarity
Added the outline-offset class to the timeline action submission buttons to improve their visual clarity. And added specifier for focus pseudo-class to offset-outline class to increase its specificity. Without this change in specificity, the class's outline-color property would be overridden by the one given to button:focus in modal.css
Examples of the changes:On the navbar |
atauln
approved these changes
Oct 29, 2025
atauln
left a comment
atauln
left a comment
There was a problem hiding this comment.
These all look like good, semantically correct changes. Variables are properly named and the spacing is consistent throughout. Looks good to me!
github-project-automation
bot
moved this from In Progress
to Under Review
in Portal Development
|
It looks like you were able to achieve this in the least amount of changes. The visible change is nicer and more accessible. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.