Skip to content

Added allowed-tools declaration to all 71 skills across 7 packs#106

Merged
dmartinol merged 7 commits into
RHEcosystemAppEng:mainfrom
r2dedios:introducing-allowed-tools
May 26, 2026
Merged

Added allowed-tools declaration to all 71 skills across 7 packs#106
dmartinol merged 7 commits into
RHEcosystemAppEng:mainfrom
r2dedios:introducing-allowed-tools

Conversation

@r2dedios
Copy link
Copy Markdown
Contributor

@r2dedios r2dedios commented May 25, 2026

Summary

Adds the allowed-tools field to the YAML frontmatter of all 71 skills across the 7 packs (ocp-admin, rh-ai-engineer, rh-automation, rh-basic, rh-developer, rh-sre, rh-virt). This field declares upfront which MCP tools each skill is permitted to use, giving the LLM an explicit boundary before it starts executing.

Skill declarations:

  • 67 new declarations added to skills that had none
  • 4 existing declarations updated for consistency (debug-rbac, debug-scc, incident-triage, vm-snapshot-create)
  • Skills that use no MCP tools declare allowed-tools: with an empty value
  • Orchestration skills list the transitive union of tools from all delegated sub-skills
  • Uses short tool names (e.g. resources_get) for straightforward validation against live MCP servers
  • Lightspeed-mcp tools use namespace prefixes (e.g. vulnerability__get_cves, inventory__find_host_by_name)

CI validator improvements (scripts/validate_mcp_tools.py):

  • Tools from non-startable MCP servers (non-container commands like npx, uvx, or empty) are now classified as WARN instead of FAIL — they can't be verified, but they don't block the PR
  • Added per-tool logging for easier debugging of tool name discrepancies
  • Removed dead queried_servers variable

CI workflow changes (.github/workflows/mcp-tool-validation.yml):

  • Added second dummy kubeconfig context so kubernetes-mcp-server exposes the configuration_contexts_list tool (requires 2+ contexts)

Documentation:

  • Added mcp-tool-validation.yml section to .github/workflows/README.md (was missing)
  • Updated workflow count from 5 to 6

Pack(s) affected

  • rh-sre
  • rh-developer
  • ocp-admin
  • rh-virt
  • rh-ai-engineer
  • Other / repo-wide

Change type

  • New skill
  • New agent
  • New pack
  • Update existing skill / agent
  • MCP server config (mcps.json)
  • Docs / README
  • CI / tooling

CLAUDE.md compliance

  • Agents orchestrate skills; no direct MCP/tool calls in agents
  • Skills are single-purpose task executors
  • Skills encapsulate all tool access (MCP tools invoked only inside skills)
  • Document consultation: file is read with the Read tool, then declared to the user
  • No credentials hardcoded; env vars used via ${VAR} references
  • Human-in-the-loop confirmation added for any destructive or critical operations

Validation

  • make validate passes locally
  • All 3 CI checks pass: mcp-tool-check, compliance-check, skill-linter
  • New/changed skills have valid YAML frontmatter (name, description)
  • allowed-tools format validated (space-delimited, short names)

@r2dedios r2dedios self-assigned this May 25, 2026
@r2dedios r2dedios added the documentation Improvements or additions to documentation label May 25, 2026
@r2dedios r2dedios marked this pull request as draft May 25, 2026 11:49
@r2dedios r2dedios marked this pull request as ready for review May 25, 2026 11:57
@r2dedios r2dedios requested a review from dmartinol May 25, 2026 11:58
@r2dedios
Copy link
Copy Markdown
Contributor Author

@dmartinol PR ready for review!

Copy link
Copy Markdown
Collaborator

@dmartinol dmartinol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! /lgtm

@dmartinol dmartinol merged commit 96aa260 into RHEcosystemAppEng:main May 26, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants