Skip to content

fix issue #55445 shibboleth skip login #1795

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ivis-kondo wants to merge 3 commits into
base: develop_v2.0.0
Choose a base branch
from
Open

fix issue #55445 shibboleth skip login #1795

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b6637d6
set cookies during login process
ryoya-hayase Oct 6, 2025
bc7e17a
fix: address review comments
ryoya-hayase Dec 25, 2025
7952e90
Merge pull request #995 from ryoya-hayase/fix/W2025-29_shibboleth_ski…
ivis-kondo Dec 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions nginx/login.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,11 +51,21 @@
response.raise_for_status()
redirect = response.text

# Get Set-Cookie headers
set_cookie_values = []
try:
set_cookie_values = response.raw.headers.getlist('Set-Cookie')
except Exception:
set_cookie_values = [response.headers.get('Set-Cookie')]

if redirect.startswith('/'):
# Redirect to the Shibboleth login
print('HTTP/1.1 302 Found')
print('Content-Type: text/html')
print('Location: ' + base_url + redirect)
for set_cookie in set_cookie_values:
if set_cookie:
print(f'Set-Cookie: {set_cookie}')
print('')
else:
# Display the login page or the page before login processing with flash message
Expand Down
Loading