basic GET arguments support (not perfect, parsing could be better) and example sketch#23
Open
openshwprojects wants to merge 4 commits intoQuickSander:masterfrom
Open
basic GET arguments support (not perfect, parsing could be better) and example sketch#23openshwprojects wants to merge 4 commits intoQuickSander:masterfrom
openshwprojects wants to merge 4 commits intoQuickSander:masterfrom
Conversation
QuickSander
requested changes
Aug 19, 2023
src/internals/HttpResource.cpp
Outdated
| return m_resource.length() > 0; | ||
| } | ||
|
|
||
| // not a perfect solution, may return incorrect argument if one is a substring (at the start) of another |
Owner
There was a problem hiding this comment.
Could you add D0xygen style commenting?
Thanks for the write up!
Author
|
Sure, I can fix the comment when I find some free time. I will also have to add decoding of HTML escaped characters, for example space, they are not currently handled correctly. |
Author
|
I've added some changes, also a basic GET escaped characters support: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Parsing could be improved because it may return "atest123" value when you search for "test123" but still it's better than nothing. I may or may not improve it later.