Add method to add additional headers#22
Open
MarcelRobitaille wants to merge 1 commit intoQuickSander:masterfrom
Open
Add method to add additional headers#22MarcelRobitaille wants to merge 1 commit intoQuickSander:masterfrom
MarcelRobitaille wants to merge 1 commit intoQuickSander:masterfrom
Conversation
Headers are stored in a linked list so there is no limit to the number of additional headers
QuickSander
reviewed
Jul 1, 2023
| } | ||
|
|
||
| void ArduinoHttpServer::AbstractStreamHttpReply::addHeader(const char* header) { | ||
| Header* h = new Header(header); |
Owner
There was a problem hiding this comment.
I can understand you want this feature, but I want to steer clear from dynamic memory allocation for this library.
I am trying to move everything to FixString instead of using new/delete (I even rather would use smart pointers instead of new/delete (and even the C-style free)).
If you want to use a linked list I would advise not embedding it inside a class named Header, but instead make a container type class that can hold Header classes.
Contributor
Author
There was a problem hiding this comment.
I completely understand not wanting dynamic memory allocation. What do you think about using an #ifdef to let the user switch between this implementation and something like #19, with the default being static?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Headers are stored in a linked list so there is no limit to the number of additional headers
Basically the same as #19 but there is no limit to the amount of additional headers.