Skip to content

Fix JSON Editor to display existing data in visual mode on mount #4977

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
pzyyll wants to merge 2 commits into
base: main
Choose a base branch
from
+21 −17
Open

Fix JSON Editor to display existing data in visual mode on mount #4977

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7d19159
fix(json-editor): show existing JSON data in visual mode on initial m…
pzyyll May 2, 2026
317c7e3
Merge branch 'QuantumNous:main' into fix/json-editor-visual-init-display
pzyyll May 19, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
38 changes: 21 additions & 17 deletions web/default/src/components/json-editor.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,6 +43,23 @@ type EditorRow = {
value: string
}

function parseJsonRows(json: string): EditorRow[] | null {
try {
if (!json.trim()) {
return []
}

const parsed = JSON.parse(json)
return Object.entries(parsed).map(([key, val], index) => ({
id: `${Date.now()}-${index}`,
key,
value: typeof val === 'object' ? JSON.stringify(val) : String(val),
}))
} catch (_error) {
return null
}
}
Comment on lines +46 to +61
Copy link
Copy Markdown
Contributor

@coderabbitai coderabbitai Bot May 19, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟠 Major | ⚡ Quick win

Add type validation to ensure parsed JSON is a plain object.

The function calls Object.entries(parsed) without checking whether parsed is actually an object. Non-object JSON values will produce incorrect results:

  • Arrays like [1, 2, 3] become rows with numeric string keys ("0", "1", "2")
  • Primitives like 123 or true become empty rows (data loss)
  • Strings like "hello" become character-indexed rows

Since the component is designed for key-value pairs (objects only), add a type guard after parsing to return null for non-object types.

🛡️ Proposed fix to validate object type 
 function parseJsonRows(json: string): EditorRow[] | null {
   try {
     if (!json.trim()) {
       return []
     }
 
     const parsed = JSON.parse(json)
+    if (typeof parsed !== 'object' || parsed === null || Array.isArray(parsed)) {
+      return null
+    }
+    
     return Object.entries(parsed).map(([key, val], index) => ({
       id: `${Date.now()}-${index}`,
       key,
       value: typeof val === 'object' ? JSON.stringify(val) : String(val),
     }))
   } catch (_error) {
     return null
   }
 }
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
function parseJsonRows(json: string): EditorRow[] | null {
try {
if (!json.trim()) {
return []
}
const parsed = JSON.parse(json)
return Object.entries(parsed).map(([key, val], index) => ({
id: `${Date.now()}-${index}`,
key,
value: typeof val === 'object' ? JSON.stringify(val) : String(val),
}))
} catch (_error) {
return null
}
}
function parseJsonRows(json: string): EditorRow[] | null {
try {
if (!json.trim()) {
return []
}
const parsed = JSON.parse(json)
if (typeof parsed !== 'object' || parsed === null || Array.isArray(parsed)) {
return null
}
return Object.entries(parsed).map(([key, val], index) => ({
id: `${Date.now()}-${index}`,
key,
value: typeof val === 'object' ? JSON.stringify(val) : String(val),
}))
} catch (_error) {
return null
}
}
🤖 Prompt for AI Agents 
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@web/default/src/components/json-editor.tsx` around lines 46 - 61,
parseJsonRows currently calls Object.entries(parsed) without ensuring parsed is
a plain object; update parseJsonRows to validate after JSON.parse that parsed is
an object suitable for key/value rows (i.e., typeof parsed === 'object', parsed
!== null, and !Array.isArray(parsed)) and return null for any non-object JSON
(arrays, primitives, strings). Keep the existing mapping to EditorRow and id
generation when the check passes; ensure the validation occurs before calling
Object.entries so non-object inputs yield null.


export function JsonEditor({
value,
onChange,
Expand All @@ -63,26 +80,13 @@ export function JsonEditor({
const resolvedKeyLabel = keyLabel ?? t('Key')
const resolvedValueLabel = valueLabel ?? t('Value')
const [mode, setMode] = useState<'visual' | 'json'>('visual')
const [rows, setRows] = useState<EditorRow[]>([])
const [rows, setRows] = useState<EditorRow[]>(() => parseJsonRows(value) ?? [])
const [jsonValue, setJsonValue] = useState(value)

const parseJsonToRows = (json: string) => {
try {
if (!json.trim()) {
setRows([])
return
}
const parsed = JSON.parse(json)
const newRows: EditorRow[] = Object.entries(parsed).map(
([key, val], index) => ({
id: `${Date.now()}-${index}`,
key,
value: typeof val === 'object' ? JSON.stringify(val) : String(val),
})
)
setRows(newRows)
} catch (_error) {
// Invalid JSON, keep current rows
const parsedRows = parseJsonRows(json)
if (parsedRows) {
setRows(parsedRows)
}
}

Expand Down