Modify spin_onehalf_triangle_heisenbergJ1J2_sqrpeps.h and corresponding tests#7
Open
qianji5 wants to merge 1 commit into
Open
Modify spin_onehalf_triangle_heisenbergJ1J2_sqrpeps.h and corresponding tests#7qianji5 wants to merge 1 commit into
qianji5 wants to merge 1 commit into
Conversation
…s.h: 1. Move the calculation of the J2 contribution on the same row window into the previous loop over col; 2. Replaced inv_psi2 with inv_psi; 3. Added the calculation of the J2 contribution (↘ with sqrt(5) separation). II. integration_test_framework.h 1. Load TPS only on the master rank, then broadcast to other ranks in RunVMCOptimization, RunMCMeasurement, and RunZeroUpdateTest; 2. Add MPI_Barrier before loading TPS in RunMCMeasurement; 3. Only compare measurement energy and energy_ed on the master rank in RunMCMeasurement. III. test_triangle_heisenberg.cpp and test_triangle_j1j2_heisenberg.cpp 1. Update energy_ed and replaced Dbmps_min and Dbmps_max with Dpeps and 2 * Dpeps.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I. EvaluateObservables in spin_onehalf_triangle_heisenbergJ1J2_sqrpeps.h:
1. Move the calculation of the J2 contribution on the same row window into the previous loop over col;
2. Replaced inv_psi2 with inv_psi;
3. Added the calculation of the J2 contribution (↘ with sqrt(5) separation).
II. integration_test_framework.h
1. Load TPS only on the master rank, then broadcast to other ranks in RunVMCOptimization, RunMCMeasurement, and RunZeroUpdateTest;
2. Add MPI_Barrier before loading TPS in RunMCMeasurement;
3. Only compare measurement energy and energy_ed on the master rank in RunMCMeasurement.
III. test_triangle_heisenberg.cpp and test_triangle_j1j2_heisenberg.cpp
1. Update energy_ed and replaced Dbmps_min and Dbmps_max with Dpeps and 2 * Dpeps.