Skip to content

Specialize non-reducing kernel: drop reduction-only iszero hoist #69

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
lkdvos wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Specialize non-reducing kernel: drop reduction-only iszero hoist #69

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
47 changes: 30 additions & 17 deletions src/mapreduce.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -340,25 +340,14 @@ function _mapreduce_kernel_expr(f, op, initop, N::Int, M::Int)
outerreturnstrideex[i] = returnex
end

i = 1
if op == Nothing
# Non-reducing (map!/permute/...): each destination element is written once,
# so skip the reduction-only `iszero` hoist below and emit just the direct
# `@simd` loop.
ex = Expr(:(=), lhsex, fcallex)
exa = Expr(:(=), :a, fcallex)
else
ex = Expr(:(=), lhsex, Expr(:call, :op, lhsex, fcallex))
exa = Expr(:(=), :a, Expr(:call, :op, :a, fcallex))
end
i = 1
if N >= 1
ex = quote
if iszero($(stridevars[1, 1])) # explicitly hoist A1[I1] out of loop
a = $lhsex
@simd for $(innerloopvars[i]) in Base.OneTo($(blockdimvars[i]))
$exa
$(stepstride2ex[i])
end
$lhsex = a
$(returnstride2ex[i])
else
if N >= 1
ex = quote
@simd for $(innerloopvars[i]) in Base.OneTo($(blockdimvars[i]))
$ex
$(stepstride1ex[i])
Expand All @@ -368,6 +357,30 @@ function _mapreduce_kernel_expr(f, op, initop, N::Int, M::Int)
$(returnstride2ex[i])
end
end
else
ex = Expr(:(=), lhsex, Expr(:call, :op, lhsex, fcallex))
exa = Expr(:(=), :a, Expr(:call, :op, :a, fcallex))
if N >= 1
ex = quote
if iszero($(stridevars[1, 1])) # explicitly hoist A1[I1] out of loop
a = $lhsex
@simd for $(innerloopvars[i]) in Base.OneTo($(blockdimvars[i]))
$exa
$(stepstride2ex[i])
end
$lhsex = a
$(returnstride2ex[i])
else
@simd for $(innerloopvars[i]) in Base.OneTo($(blockdimvars[i]))
$ex
$(stepstride1ex[i])
$(stepstride2ex[i])
end
$(returnstride1ex[i])
$(returnstride2ex[i])
end
end
end
end
for outer i in 2:N
ex = quote
Expand Down
Loading