Skip to content

Separate Algorithm and Driver - part III (Schur-Eig)#194

Open
lkdvos wants to merge 15 commits intomainfrom
ld-algmerge3
Open

Separate Algorithm and Driver - part III (Schur-Eig)#194
lkdvos wants to merge 15 commits intomainfrom
ld-algmerge3

Conversation

@lkdvos
Copy link
Member

@lkdvos lkdvos commented Mar 19, 2026

Follow-up on #178 and #189, addressing #176.

Same treatment for eig, eigh and schur functions.

@leburgel leburgel added the documentation Improvements or additions to documentation label Mar 19, 2026
@github-actions
Copy link

After the build completes, the updated documentation will be available here

@leburgel
Copy link
Member

The lists of available algorithms in the user interface page should also be updated, they still point to the LAPACK-specific algorithms through

Filter = t -> t isa Type && t <: MatrixAlgebraKit.LAPACK_EighAlgorithm

which should become <: MatrixAlgebraKit.EighAlgorithms.

@lkdvos lkdvos requested a review from Jutho March 20, 2026 15:33
@lkdvos
Copy link
Member Author

lkdvos commented Mar 20, 2026

GPU failures are again the memory issues. Should be good to go!

const LAPACK_EigAlgorithm = Union{LAPACK_Simple, LAPACK_Expert}
const CUSOLVER_EigAlgorithm = Union{CUSOLVER_Simple}
const GPU_EigAlgorithm = Union{GPU_Simple}
const EigAlgorithms = Union{QRIteration, RobustRepresentations}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are these leftovers or aliases? I think LAPACK_Simple is now deprecated?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

They're leftover but i can't delete them without making things breaking I think

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you're still up for it, maybe add a comment or put them in a deprecations section on this page. If not, we will notice when we delete the deprecated algorithms.

lkdvos and others added 2 commits March 20, 2026 18:04
Co-authored-by: Jutho <Jutho@users.noreply.github.com>
@codecov
Copy link

codecov bot commented Mar 20, 2026

Codecov Report

❌ Patch coverage is 90.38462% with 10 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
src/implementations/eig.jl 82.60% 4 Missing ⚠️
src/implementations/schur.jl 80.95% 4 Missing ⚠️
...ixAlgebraKitAMDGPUExt/MatrixAlgebraKitAMDGPUExt.jl 80.00% 1 Missing ⚠️
src/implementations/eigh.jl 95.65% 1 Missing ⚠️
Files with missing lines Coverage Δ
...MatrixAlgebraKitCUDAExt/MatrixAlgebraKitCUDAExt.jl 73.68% <100.00%> (-0.46%) ⬇️
ext/MatrixAlgebraKitGenericLinearAlgebraExt.jl 85.29% <100.00%> (+0.44%) ⬆️
ext/MatrixAlgebraKitGenericSchurExt.jl 100.00% <100.00%> (ø)
src/MatrixAlgebraKit.jl 100.00% <ø> (ø)
src/algorithms.jl 85.71% <100.00%> (+0.09%) ⬆️
src/implementations/svd.jl 94.41% <ø> (+0.30%) ⬆️
src/interface/decompositions.jl 76.19% <ø> (ø)
src/interface/eig.jl 72.22% <100.00%> (ø)
src/interface/eigh.jl 68.42% <100.00%> (ø)
...ixAlgebraKitAMDGPUExt/MatrixAlgebraKitAMDGPUExt.jl 68.51% <80.00%> (-0.58%) ⬇️
... and 3 more

... and 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants