Skip to content

Counter-attack TNRKit with increased coverage#190

Merged
kshyatt merged 9 commits intomainfrom
ksh/cov
Mar 18, 2026
Merged

Counter-attack TNRKit with increased coverage#190
kshyatt merged 9 commits intomainfrom
ksh/cov

Conversation

@kshyatt
Copy link
Member

@kshyatt kshyatt commented Mar 17, 2026

So that we can stop getting bullied by TNRKit

@kshyatt kshyatt requested a review from Jutho March 17, 2026 12:56
@lkdvos
Copy link
Member

lkdvos commented Mar 17, 2026

Can you not just exclude them from coverage?
These might still be useful somewhere, for example KrylovKit still has its own LAPACK wrappers in some places that might eventually make their way here.

@eval begin
# Flexible QR / LQ
function geqr!(A::AbstractMatrix{$elty})
#=function geqr!(A::AbstractMatrix{$elty})
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we should actually start using this one if no explicit block size is given. It lowers to two different implementations depending on the m versus n ratio, and chooses an optimal block size.

@kshyatt
Copy link
Member Author

kshyatt commented Mar 17, 2026

@lkdvos we discussed at lunch and initially the decision was comment out, my concern with coverage exclusion is people forgetting to include them when we start using them...

@Jutho
Copy link
Member

Jutho commented Mar 17, 2026

By now, the title of this PR can probably be changed to "Increase coverage to set a new TNRKit target".

@kshyatt kshyatt changed the title Comment out unused LAPACK wrappers for coverage Counter-attack TNRKit with increased coverage Mar 17, 2026
@codecov
Copy link

codecov bot commented Mar 17, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.

Files with missing lines Coverage Δ
src/yalapack.jl 85.16% <ø> (+20.21%) ⬆️

... and 10 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@kshyatt kshyatt merged commit 5a65804 into main Mar 18, 2026
8 of 9 checks passed
@kshyatt kshyatt deleted the ksh/cov branch March 18, 2026 10:35
@VictorVanthilt
Copy link
Member

I come in peace and vow to work on myself (Improve our coverage).

@kshyatt
Copy link
Member Author

kshyatt commented Mar 18, 2026

I come in peace and vow to work on myself (Improve our coverage).

My evil plan continues to advance...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants