Conversation
|
Can you not just exclude them from coverage? |
| @eval begin | ||
| # Flexible QR / LQ | ||
| function geqr!(A::AbstractMatrix{$elty}) | ||
| #=function geqr!(A::AbstractMatrix{$elty}) |
There was a problem hiding this comment.
Maybe we should actually start using this one if no explicit block size is given. It lowers to two different implementations depending on the m versus n ratio, and chooses an optimal block size.
|
@lkdvos we discussed at lunch and initially the decision was comment out, my concern with coverage exclusion is people forgetting to include them when we start using them... |
|
By now, the title of this PR can probably be changed to "Increase coverage to set a new TNRKit target". |
Codecov Report✅ All modified and coverable lines are covered by tests.
... and 10 files with indirect coverage changes 🚀 New features to boost your workflow:
|
|
I come in peace and vow to work on myself (Improve our coverage). |
My evil plan continues to advance... |
So that we can stop getting bullied by TNRKit