Skip to content

Support for Diagonal in orthnull #144

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Jutho merged 3 commits into from
Mar 20, 2026
+10 −4
Merged

Support for Diagonal in orthnull #144

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d546165
Support orthnull for Diagonal
kshyatt Jan 6, 2026
abefa42
Update src/interface/orthnull.jl
kshyatt Mar 20, 2026
ae8805f
Update src/interface/orthnull.jl
kshyatt Mar 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions src/interface/orthnull.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -443,7 +443,9 @@ left_orth_alg(alg::LeftOrthAlgorithm) = alg
left_orth_alg(alg::QRAlgorithms) = LeftOrthViaQR(alg)
left_orth_alg(alg::PolarAlgorithms) = LeftOrthViaPolar(alg)
left_orth_alg(alg::SVDAlgorithms) = LeftOrthViaSVD(alg)
left_orth_alg(alg::DiagonalAlgorithm) = LeftOrthViaQR(alg)
left_orth_alg(alg::TruncatedAlgorithm{<:SVDAlgorithms}) = LeftOrthViaSVD(alg)
left_orth_alg(alg::TruncatedAlgorithm{<:DiagonalAlgorithm}) = LeftOrthViaSVD(alg)

"""
right_orth_alg(alg::AbstractAlgorithm) -> RightOrthAlgorithm
Expand Down Expand Up @@ -478,7 +480,9 @@ right_orth_alg(alg::RightOrthAlgorithm) = alg
right_orth_alg(alg::LQAlgorithms) = RightOrthViaLQ(alg)
right_orth_alg(alg::PolarAlgorithms) = RightOrthViaPolar(alg)
right_orth_alg(alg::SVDAlgorithms) = RightOrthViaSVD(alg)
right_orth_alg(alg::DiagonalAlgorithm) = RightOrthViaLQ(alg)
right_orth_alg(alg::TruncatedAlgorithm{<:SVDAlgorithms}) = RightOrthViaSVD(alg)
right_orth_alg(alg::TruncatedAlgorithm{<:DiagonalAlgorithm}) = RightOrthViaSVD(alg)

"""
left_null_alg(alg::AbstractAlgorithm) -> LeftNullAlgorithm
Expand Down
2 changes: 1 addition & 1 deletion test/linearmap.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ module LinearMaps
# Using AbstractAlgorithm here would be ambiguous since neither A-type nor alg-type would
# be strictly more specific.
for f! in (:svd_compact!, :svd_full!)
for Alg in (:SafeDivideAndConquer, :DivideAndConquer, :QRIteration, :Bisection, :Jacobi, :SVDViaPolar)
for Alg in (:SafeDivideAndConquer, :DivideAndConquer, :QRIteration, :Bisection, :Jacobi, :SVDViaPolar, :DiagonalAlgorithm)
@eval MAK.$f!(A::LinearMap, USVᴴ, alg::MAK.$Alg) =
LinearMap.(MAK.$f!(parent(A), parent.(USVᴴ), alg))
end
Expand Down
6 changes: 3 additions & 3 deletions test/orthnull.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,16 +19,16 @@ for T in (BLASFloats..., GenericFloats...), n in (17, m, 27)
if T ∈ BLASFloats
if CUDA.functional()
TestSuite.test_orthnull(CuMatrix{T}, (m, n); test_nullity = false)
n == m && TestSuite.test_orthnull(Diagonal{T, CuVector{T}}, m; test_orthnull = false)
n == m && TestSuite.test_orthnull(Diagonal{T, CuVector{T}}, m)
end
if AMDGPU.functional()
TestSuite.test_orthnull(ROCMatrix{T}, (m, n); test_nullity = false)
n == m && TestSuite.test_orthnull(Diagonal{T, ROCVector{T}}, m; test_orthnull = false)
n == m && TestSuite.test_orthnull(Diagonal{T, ROCVector{T}}, m)
end
end
if !is_buildkite
TestSuite.test_orthnull(T, (m, n))
AT = Diagonal{T, Vector{T}}
TestSuite.test_orthnull(AT, m; test_orthnull = false)
TestSuite.test_orthnull(AT, m)
end
end
2 changes: 2 additions & 0 deletions test/testsuite/TestSuite.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,9 +76,11 @@ is_pivoted(alg::MatrixAlgebraKit.LQViaTransposedQR) = is_pivoted(alg.qr_alg)
isleftcomplete(V, N) = V * V' + N * N' ≈ I
isleftcomplete(V::AnyCuMatrix, N::AnyCuMatrix) = isleftcomplete(collect(V), collect(N))
isleftcomplete(V::AnyROCMatrix, N::AnyROCMatrix) = isleftcomplete(collect(V), collect(N))
isleftcomplete(V::Diagonal{TV, <:AnyROCVector}, N::AnyROCMatrix) where {TV} = isleftcomplete(Diagonal(collect(V.diag)), collect(N))
isrightcomplete(Vᴴ, Nᴴ) = Vᴴ' * Vᴴ + Nᴴ' * Nᴴ ≈ I
isrightcomplete(V::AnyCuMatrix, N::AnyCuMatrix) = isrightcomplete(collect(V), collect(N))
isrightcomplete(V::AnyROCMatrix, N::AnyROCMatrix) = isrightcomplete(collect(V), collect(N))
isrightcomplete(V::Diagonal{TV, <:AnyROCVector}, N::AnyROCMatrix) where {TV} = isrightcomplete(Diagonal(collect(V.diag)), collect(N))

instantiate_unitary(T, A, sz) = qr_compact(randn!(similar(A, eltype(T), sz, sz)))[1]
# AMDGPU can't generate ComplexF32 random numbers
Expand Down
Loading