fix: detect skipped downloads despite streamrip's RichHandler line wrapping#20
Merged
Conversation
…apping
streamrip logs the per-track skip line ("...Marked as downloaded in the
database.") through rich's RichHandler, which wraps to the console width.
When rip runs as a subprocess with a piped (non-tty) stdout that width
defaults to 80 columns, so the phrase skip detection keys on wraps mid-line
(with rich's right-aligned source location dropped into the gap). SKIP_LINE_RE
then never matches and an already-downloaded album is misclassified as a fresh
completion, losing its "already downloaded" state.
Force a wide COLUMNS on the spawned rip via a new _rip_runner_env() helper
(applied to both the download and search runners); the runner's per-line strip
drops the resulting trailing padding. Add a regression test that drives the
real runner through an actual RichHandler — the fake-runner tests feed clean
single-line strings and so never exercised the wrap. Add rich to dev deps so
that test runs in CI instead of skipping.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.