README: document enabling/disabling services#304
Open
rmelotte wants to merge 1 commit intoQuantumEntangledAndy:masterfrom
Open
README: document enabling/disabling services#304rmelotte wants to merge 1 commit intoQuantumEntangledAndy:masterfrom
rmelotte wants to merge 1 commit intoQuantumEntangledAndy:masterfrom
Conversation
QuantumEntangledAndy
requested changes
Oct 15, 2024
Owner
QuantumEntangledAndy
left a comment
There was a problem hiding this comment.
Could you make it clear that this is not the same rtsp as provided elsewhere. People tend to skim the readme for keywords such as rtsp and might think they need to enable the service
Support for enabling/disabling services has been added in 54f7665 but was so far not documented, which made it hard to find. This is a very useful feature for people who prefer to avoid relying on the proprietary application to enable services, so add it to the main README file. Signed-off-by: Raphaël Mélotte <raphael.melotte@mind.be>
85ee19a to
92a66af
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Support for enabling/disabling services has been added in 54f7665 but was so far not documented, which made it hard to find.
This is a very useful feature for people who prefer to avoid relying on the proprietary application to enable services, so add it to the main README file.