Add Party Coordination for Secret Waypoints Overview

JAVAFX_FIX.md

@@ -0,0 +1,132 @@
+# JavaFX Compatibility Fix
+
+## Problem
+The video player crashed with `java.lang.NoClassDefFoundError: javafx/scene/image/Image` because JavaFX classes were not available in the Minecraft launcher's Java runtime.
+
+## Root Cause
+- Minecraft launchers (especially modded ones) often use stripped-down JRE distributions that don't include JavaFX
+- JavaFX was bundled with Oracle JDK 8 but not with all JRE distributions
+- Starting with Java 11, JavaFX was completely removed from the JDK and became a separate module
+
+## Solution Implemented
+Added comprehensive JavaFX availability checks throughout the video player system to gracefully handle missing JavaFX:
+
+### 1. **VideoPlayer.java** - Core availability detection
+```java
+private static boolean javafxAvailable = false;
+
+static {
+    try {
+        Class.forName("javafx.application.Platform");
+        javafxAvailable = true;
+    } catch (ClassNotFoundException e) {
+        System.err.println("JavaFX is not available - Video player will be disabled");
+        javafxAvailable = false;
+    }
+}
+
+public static boolean isJavaFXAvailable() {
+    return javafxAvailable;
+}
+```
+
+- Added static initializer block that checks for JavaFX classes at class load time
+- All methods now check `javafxAvailable` before executing JavaFX code
+- Prevents `NoClassDefFoundError` by detecting missing classes early
+
+### 2. **VideoRenderer.java** - Safe rendering
+```java
+public void renderVideoOverlay() {
+    if (!enabled || !VideoPlayer.isJavaFXAvailable()) {
+        return;
+    }
+    // ... rest of rendering code
+}
+```
+
+- Checks JavaFX availability before attempting any rendering operations
+- Prevents crashes during the render loop
+
+### 3. **VideoEventHandler.java** - User-friendly messaging
+```java
+@SubscribeEvent
+public void onRenderOverlay(RenderGameOverlayEvent.Post event) {
+    if (!VideoPlayer.isJavaFXAvailable()) {
+        return; // Silently skip if JavaFX not available
+    }
+    // ... rendering code
+}
+
+// In key handler:
+if (key == Keyboard.KEY_V) {
+    if (!VideoPlayer.isJavaFXAvailable()) {
+        Minecraft.getMinecraft().thePlayer.addChatMessage(
+            new ChatComponentText("§6[Dungeon Rooms] §cVideo player unavailable - JavaFX not found")
+        );
+        return;
+    }
+    // ... toggle code
+}
+```
+
+- Added early return in render event handler (line 34 where crash occurred)
+- Shows helpful error message to user when they try to use video player
+- Prevents all video-related key handlers from executing without JavaFX
+
+### 4. **VideoPlayerGUI.java** - Informative error screen
+```java
+@Override
+public void drawScreen(int mouseX, int mouseY, float partialTicks) {
+    this.drawDefaultBackground();
+
+    if (!VideoPlayer.isJavaFXAvailable()) {
+        // Display error message
+        this.drawCenteredString("§c§lJavaFX Not Available", ...);
+        this.drawCenteredString("§eThe video player requires JavaFX which is not available", ...);
+        this.drawCenteredString("§ein your current Java installation.", ...);
+        return;
+    }
+    // ... normal GUI rendering
+}
+```
+
+- Shows clear error message when GUI is opened without JavaFX
+- Prevents initialization of GUI components that require JavaFX
+- User-friendly explanation instead of a crash
+
+## Benefits
+
+1. **No More Crashes**: Mod loads successfully even without JavaFX
+2. **Graceful Degradation**: Video player feature is disabled, but all other mod features work
+3. **User Feedback**: Clear messages explain why video player isn't working
+4. **Backward Compatible**: Works on all Minecraft launcher distributions
+5. **Future-Proof**: Handles Java 11+ environments where JavaFX is always separate
+
+## Testing
+
+Build successful with all safety checks in place:
+```
+BUILD SUCCESSFUL in 14s
+14 actionable tasks: 10 executed, 4 up-to-date
+```
+
+## User Experience
+
+### With JavaFX available:
+- Video player works normally
+- All features functional
+
+### Without JavaFX (most users):
+- Mod loads without errors
+- Pressing 'V' key shows: "§6[Dungeon Rooms] §cVideo player unavailable - JavaFX not found"
+- Opening video player GUI (U key) shows informative error screen
+- All other mod features (waypoints, party coordination, etc.) work perfectly
+
+## Future Considerations
+
+To make the video player work for all users, would need to either:
+1. Bundle JavaFX libraries with the mod (increases mod size significantly)
+2. Use a different video rendering approach (VLC, native codecs, etc.)
+3. Document JavaFX installation instructions for users who want the feature
+
+For now, the graceful degradation approach ensures the mod works for everyone, with video player as an optional bonus feature for users who have JavaFX.

README.md

@@ -29,6 +29,9 @@ Short answer: This mod follows the general interpretation of Hypixel's rules, do
 
 Long Answer: https://quantizr.github.io/posts/is-it-bannable/
 
+### What is new in this fork?
+When a secret is opened it will remove the waypoint for anyone else using this fork. That way, if you have those people that open a room, get 2 or 3 secrets and leave, you can see (or rather no longer can see) which ones they opened!
+
 
 ### Discord:
 [![Discord](https://img.shields.io/discord/804143990869590066?color=%239f00ff&label=Discord&style=for-the-badge)](https://discord.gg/7B5RbsArYK)

VIDEO_PLAYER_GUIDE.md

@@ -0,0 +1,97 @@
+# Video Player Feature Guide
+
+## Overview
+The video player overlay allows you to watch videos while playing Minecraft dungeons. It uses JavaFX (built into Java 8) to render video content over the game.
+
+## Files Created/Modified
+
+### New Files:
+1. **VideoPlayer.java** - Singleton managing JavaFX MediaPlayer
+2. **VideoRenderer.java** - OpenGL overlay rendering with DynamicTexture
+3. **VideoEventHandler.java** - Forge event handler for rendering and input
+4. **VideoPlayerGUI.java** - GUI with file browser and playback controls
+
+### Modified Files:
+1. **DungeonRooms.java** - Added video event handler registration and keybinding
+
+## Controls
+
+### Opening the Video Player GUI:
+- Press **U** (default keybinding)
+- Configurable in Minecraft Controls menu under "Dungeon Rooms Mod"
+
+### Video Overlay Controls:
+- **V** - Toggle video overlay on/off
+- **Space** - Play/Pause
+- **Left Arrow** - Seek backward 5 seconds
+- **Right Arrow** - Seek forward 5 seconds
+- **Up Arrow** - Increase volume
+- **Down Arrow** - Decrease volume
+- **+** (Plus/Equals key) - Increase opacity
+- **-** (Minus key) - Decrease opacity
+
+## Usage
+
+1. **Load a Video:**
+   - Press **U** to open the Video Player GUI
+   - Click "Browse" to select a video file OR manually enter a file path
+   - Supported formats: MP4, AVI, MKV, MOV, FLV, WMV
+   - Click "Load Video"
+
+2. **Control Playback:**
+   - Use the GUI buttons OR close the GUI and use keyboard shortcuts
+   - The video will loop automatically when it reaches the end
+
+3. **Toggle Overlay:**
+   - Press **V** to show/hide the video while playing
+   - Video continues playing in the background when hidden
+
+## Technical Details
+
+- **Video Size:** Default 854x480 pixels (centered on screen)
+- **Opacity:** Default 0.6 (60% transparent), adjustable 0.1-1.0
+- **Performance:** Uses hardware-accelerated JavaFX rendering
+- **Thread Safety:** All JavaFX operations wrapped in Platform.runLater
+- **Looping:** Videos automatically loop indefinitely
+
+## Building
+
+The video player is fully integrated. Simply build the mod as usual:
+```
+.\gradlew.bat build
+```
+
+The compiled mod will be in: `build\libs\dungeonrooms-1.0.jar`
+
+## Tips
+
+1. **Pre-download Videos:** Download videos locally for best performance (no streaming)
+2. **Adjust Opacity:** Use +/- keys to find the right transparency for your needs
+3. **Practice Mode:** Works great with waypoint practice mode - watch tutorials while learning!
+4. **Keybind Conflicts:** Check Minecraft Controls menu if keys don't work
+
+## Troubleshooting
+
+**Video won't load:**
+- Ensure file path is correct
+- Check file format is supported
+- Try a different video file
+
+**Overlay not showing:**
+- Press V to toggle overlay
+- Check if video is actually loaded and playing
+- Look for chat messages indicating video state
+
+**Performance issues:**
+- Use smaller video resolutions (720p or lower recommended)
+- Close video player when not in use
+- Lower video opacity can improve visibility with less distraction
+
+## Party Coordination Integration
+
+This video player works alongside the party coordination features:
+- SS-FOUND messages won't interfere with video overlay
+- Video continues playing while in dungeons
+- Perfect for watching during repetitive farming sessions
+
+Enjoy your video overlay! 🎥

src/main/java/io/github/quantizr/dungeonrooms/DungeonRooms.java

@@ -24,13 +24,15 @@
 import io.github.quantizr.dungeonrooms.commands.RoomCommand;
 import io.github.quantizr.dungeonrooms.dungeons.catacombs.Waypoints;
 import io.github.quantizr.dungeonrooms.gui.WaypointsGUI;
+import io.github.quantizr.dungeonrooms.gui.VideoPlayerGUI;
 import io.github.quantizr.dungeonrooms.handlers.ConfigHandler;
 import io.github.quantizr.dungeonrooms.handlers.OpenLink;
 import io.github.quantizr.dungeonrooms.handlers.PacketHandler;
 import io.github.quantizr.dungeonrooms.handlers.TextRenderer;
 import io.github.quantizr.dungeonrooms.dungeons.catacombs.DungeonManager;
 import io.github.quantizr.dungeonrooms.dungeons.catacombs.RoomDetection;
 import io.github.quantizr.dungeonrooms.utils.Utils;
+import io.github.quantizr.dungeonrooms.video.VideoEventHandler;
 import net.minecraft.client.Minecraft;
 import net.minecraft.client.entity.EntityPlayerSP;
 import net.minecraft.client.gui.ScaledResolution;
@@ -84,7 +86,7 @@ public class DungeonRooms
     public static HashMap<String,HashMap<String,long[]>> ROOM_DATA = new HashMap<>();
 
     public static boolean usingSBPSecrets = false;
-    public static KeyBinding[] keyBindings = new KeyBinding[3];
+    public static KeyBinding[] keyBindings = new KeyBinding[4];
     public static String imageHotkeyOpen = "gui";
     static int tickAmount = 1;
 
@@ -127,6 +129,7 @@ public void init(FMLInitializationEvent event) {
         MinecraftForge.EVENT_BUS.register(new DungeonManager());
         MinecraftForge.EVENT_BUS.register(new RoomDetection());
         MinecraftForge.EVENT_BUS.register(new Waypoints());
+        MinecraftForge.EVENT_BUS.register(new VideoEventHandler());
 
         //reload config
         ConfigHandler.reloadConfig();
@@ -135,6 +138,7 @@ public void init(FMLInitializationEvent event) {
         keyBindings[0] = new KeyBinding("Open Room Images in DSG/SBP", Keyboard.KEY_O, "Dungeon Rooms Mod");
         keyBindings[1] = new KeyBinding("Open Waypoint Config Menu", Keyboard.KEY_P, "Dungeon Rooms Mod");
         keyBindings[2] = new KeyBinding("Show Waypoints in Practice Mode", Keyboard.KEY_I, "Dungeon Rooms Mod");
+        keyBindings[3] = new KeyBinding("Open Video Player", Keyboard.KEY_U, "Dungeon Rooms Mod");
         for (KeyBinding keyBinding : keyBindings) {
             ClientRegistry.registerKeyBinding(keyBinding);
         }
@@ -303,6 +307,14 @@ public void onKey(InputEvent.KeyInputEvent event) {
                         + "Dungeon Rooms: Waypoints must be enabled for Practice Mode to work."));
             }
         }
+        if (keyBindings[3].isPressed()) {
+            try {
+                mc.addScheduledTask(() -> mc.displayGuiScreen(new VideoPlayerGUI()));
+            } catch (NoClassDefFoundError e) {
+                player.addChatMessage(new ChatComponentText(EnumChatFormatting.RED
+                        + "Dungeon Rooms: Video player unavailable - JavaFX not found"));
+            }
+        }
     }
 
     @SubscribeEvent