In place update to syntax errors, deprecated code, unused variables

[mohiteamit]

Updated made to following dimensions/reader.py

1. Updated deprecated code (datafarme.ix --> dataframe.loc)
2. Fix call to datetime64 to reflect python 3 compatible numpy version
3. Commented lines with unused variables
4. Updated correct return variables for quantipy_from_dimensions.

[geirfreysson]

This doesn't break any tests, but the dimensions reader part isn't the best tested bit of Quantipy. Do we want to merge this - do we have any testing data for before/after?

[mohiteamit]

Since I submitted this, I have found more things which need to be fixed so do not merge this. Quantipy assumes very simple format of MDD whereas it is never true at least in business I work with. I trying work my way to accommodate more of MDD complexity. I suggest to close the thread if required. Get Outlook for iOS<https://aka.ms/o0ukef>

…

________________________________ From: Geir Freysson <notifications@github.com> Sent: Thursday, March 4, 2021 3:02:56 AM To: Quantipy/quantipy3 <quantipy3@noreply.github.com> Cc: Amit Mohite <amit.mohite@outlook.com>; Author <author@noreply.github.com> Subject: Re: [Quantipy/quantipy3] In place update to syntax errors, deprecated code, unused variables (#14) This doesn't break any tests, but the dimensions reader part isn't the best tested bit of Quantipy. Do we want to merge this - do we have any testing data for before/after? — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub<#14 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/APFBA3YRVUW2IQZ4LPWU5U3TB2TIRANCNFSM4MLVE4GQ>.