Skip to content

refactor: Replace portgraph toposort in CommandIterator with node vector#1608

Merged
aborgna-q merged 2 commits into
mainfrom
ab/scheduling-graph-in-commands
May 20, 2026
Merged

refactor: Replace portgraph toposort in CommandIterator with node vector#1608
aborgna-q merged 2 commits into
mainfrom
ab/scheduling-graph-in-commands

Conversation

@aborgna-q
Copy link
Copy Markdown
Collaborator

Replaces the deprecated hugr.region_portgraph call by using hugr.scheduling_graph and eagerly collecting the toposorted node list.

This is necessary for #1580 since region_portgraph has been removed in the update.

I'll follow up this PR with another deprecating CommandsIterator.

@aborgna-q aborgna-q requested a review from a team as a code owner May 19, 2026 15:30
@codecov
Copy link
Copy Markdown

codecov Bot commented May 19, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 85.44%. Comparing base (d5890d6) to head (6f9c572).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1608      +/-   ##
==========================================
- Coverage   85.46%   85.44%   -0.02%     
==========================================
  Files         184      184              
  Lines       28772    28768       -4     
  Branches    27571    27567       -4     
==========================================
- Hits        24591    24582       -9     
- Misses       3054     3055       +1     
- Partials     1127     1131       +4     
Flag Coverage Δ
python 90.45% <ø> (ø)
qis-compiler 91.66% <ø> (ø)
rust 85.22% <100.00%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Comment thread tket/src/circuit/command.rs Outdated
@aborgna-q aborgna-q added this pull request to the merge queue May 20, 2026
Merged via the queue into main with commit f5952d4 May 20, 2026
24 checks passed
@aborgna-q aborgna-q deleted the ab/scheduling-graph-in-commands branch May 20, 2026 11:02
@hugrbot hugrbot mentioned this pull request May 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants