Skip to content

fix: Support type arguments in tuple/untuple pass#1583

Open
maximilianruesch wants to merge 3 commits into
mr/chore/update-hugr-0.28from
mr/fix/tuple-untuple-type-params
Open

fix: Support type arguments in tuple/untuple pass#1583
maximilianruesch wants to merge 3 commits into
mr/chore/update-hugr-0.28from
mr/fix/tuple-untuple-type-params

Conversation

@maximilianruesch
Copy link
Copy Markdown
Collaborator

@maximilianruesch maximilianruesch commented May 12, 2026

Requires Quantinuum/hugr#3056 to be merged and released.

Based on #1580

Closes #1486

@codecov
Copy link
Copy Markdown

codecov Bot commented May 12, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
⚠️ Please upload report for BASE (mr/chore/update-hugr-0.28@285d5b9). Learn more about missing BASE report.

Additional details and impacted files
@@                     Coverage Diff                      @@
##             mr/chore/update-hugr-0.28    #1583   +/-   ##
============================================================
  Coverage                             ?   84.01%           
============================================================
  Files                                ?      188           
  Lines                                ?    29115           
  Branches                             ?    27989           
============================================================
  Hits                                 ?    24461           
  Misses                               ?     3478           
  Partials                             ?     1176           
Flag Coverage Δ
python 92.39% <ø> (?)
rust 83.67% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

…pe-params

# Conflicts:
#	Cargo.lock
#	Cargo.toml
@maximilianruesch
Copy link
Copy Markdown
Collaborator Author

Nevermind the CI failures right now, this can only be merged once hugr is updated anyway.

@maximilianruesch maximilianruesch marked this pull request as ready for review May 12, 2026 16:18
@maximilianruesch maximilianruesch requested a review from a team as a code owner May 12, 2026 16:18
Copy link
Copy Markdown
Collaborator

@aborgna-q aborgna-q left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice.

Approving this now, but you may want to merge into main directly once the hugr update is done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: PanicException: Failed to create replacement for removing tuple pack/unpack operations when applying NormalizeGuppy

2 participants