feat: Add python definitions for the TKET metadata keys#1535
Merged
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1535 +/- ##
==========================================
- Coverage 84.09% 84.05% -0.05%
==========================================
Files 188 189 +1
Lines 29298 29358 +60
Branches 28172 28174 +2
==========================================
+ Hits 24639 24676 +37
- Misses 3479 3502 +23
Partials 1180 1180
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
acl-cqc
approved these changes
May 12, 2026
| KEY = _metadata.CIRCUIT_REWRITE_TRACES | ||
|
|
||
|
|
||
| class Unitary(Metadata[int]): |
Contributor
There was a problem hiding this comment.
Maybe UnitaryFlags? It's definitely not a unitary (i.e. matrix) itself
| KEY = _metadata.INPUT_PARAMETERS | ||
|
|
||
|
|
||
| class OpGroup(Metadata[str]): |
Contributor
There was a problem hiding this comment.
Perhaps PytketOpGroup? And elsewhere in this file for other metadata relating to pytket, but there are some that are not
| return _read_pytket_register(cls.KEY, value) | ||
|
|
||
|
|
||
| class Phase(Metadata[str]): |
| individual_matches: int | ||
|
|
||
|
|
||
| class MaxQubits(Metadata[int]): |
Contributor
There was a problem hiding this comment.
Should this be MaxQubitsHint?
| >>> node.metadata.get(QubitRegisters) | ||
| [('q', [0]), ('ancilla', [1])] | ||
| """ | ||
| # Changes to this file **MUST** be reflected in `tket/src/metadata.rs` |
Contributor
There was a problem hiding this comment.
In the sense that they ought to match, but this doesn't mean that things will break if they don't match, right? Isn't that SHOULD ?
Contributor
There was a problem hiding this comment.
I guess this means that all of my suggested renames should be applied on the rust side too, heh
Collaborator
Author
There was a problem hiding this comment.
Changed to a SHOULD. I'll do the renaming on both rust and python (with some aliases for backwards compatibility)
This was referenced May 12, 2026
Merged
jpacold
pushed a commit
to jpacold/tket2
that referenced
this pull request
May 23, 2026
🤖 I have created a release *beep* *boop* --- ## [0.13.1](Quantinuum/tket2@tket-py-v0.13.0...tket-py-v0.13.1) (2026-05-19) ### Features * Add python definitions for the TKET metadata keys ([Quantinuum#1535](Quantinuum#1535)) ([1bfef9a](Quantinuum@1bfef9a)) * Clean Up by Deleting Unconnected Nodes after Modifier Solve ([Quantinuum#1557](Quantinuum#1557)) ([d706867](Quantinuum@d706867)) * expose the QSystemPass to Python ([Quantinuum#1556](Quantinuum#1556)) ([394a610](Quantinuum@394a610)) * InlineFunctionsPass ([Quantinuum#1524](Quantinuum#1524)) ([f40dcef](Quantinuum@f40dcef)) * InlineHint metadata ([Quantinuum#1532](Quantinuum#1532)) ([e7949c2](Quantinuum@e7949c2)) ### Bug Fixes * Apply modifiers through function calls ([Quantinuum#1531](Quantinuum#1531)) ([6a13f0c](Quantinuum@6a13f0c)) * Incorrect matching of pytket parameters to unsupported graph ports ([Quantinuum#1561](Quantinuum#1561)) ([4fc5a25](Quantinuum@4fc5a25)) * Passes with Nested Modifier ([Quantinuum#1546](Quantinuum#1546)) ([bf6df51](Quantinuum@bf6df51)) * Update examples link in README.md ([Quantinuum#1506](Quantinuum#1506)) ([9a25ec8](Quantinuum@9a25ec8)) ### Documentation * Simplify package description. ([Quantinuum#1547](Quantinuum#1547)) ([54e855f](Quantinuum@54e855f)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). --------- Co-authored-by: Agustín Borgna <agustin.borgna@quantinuum.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We should also add a metadata for inline hints either here or in #1532, whichever gets merged second.