fix: add timeout parameter to circuits.cost#342
Open
JelenaMack wants to merge 4 commits into
Open
Conversation
qnx.jobs.wait_for has a timeout parameter that is set to 900 as a default. There was not way for the user to override this parameter when calling circuits.cost. Thus, as soon as the circuit execution on the syntax checker took longer than 900s, circuits.cost raises a timeout error. Therefore, this commit adds an optional timeout parameter to circuits.cost. If the user specifies nothing, qnx.jobs.wait_for will use its own default timeout value of 900. Thus, this minor change will not break any previously written code.
JelenaMack
changed the title
JelenaMack
changed the title
vanyae-cqc
requested changes
May 21, 2026
Collaborator
vanyae-cqc
left a comment
vanyae-cqc
left a comment
There was a problem hiding this comment.
Thank you @JelenaMack - could you please add the same to qnexus.client.hugr.py::cost and qnexus.client.qir.py::cost for consistency?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
qnx.jobs.wait_for has a timeout parameter that is set to 900 as a default.
There was not way for the user to override this parameter when calling circuits.cost. Thus, as soon as the circuit execution on the syntax checker took longer than 900s, circuits.cost raises an exception. Therefore, this commit adds an optional timeout parameter to circuits.cost. If the user specifies nothing, qnx.jobs.wait_for will use its own default timeout value of 900. Thus, this minor change will not break any previously written code.