Skip to content

Add DisCoCirc tutorial on babi task#42

Closed
ouissal-moumou wants to merge 10 commits intoQuantinuum:mainfrom
ouissal-moumou:Ouissal/tutorials-babi6
Closed

Add DisCoCirc tutorial on babi task#42
ouissal-moumou wants to merge 10 commits intoQuantinuum:mainfrom
ouissal-moumou:Ouissal/tutorials-babi6

Conversation

@ouissal-moumou
Copy link

@ouissal-moumou ouissal-moumou commented Feb 11, 2025

This adds a tutorial showing how to use a DisCoCirc model for solving the babi6 task.

This is the first version of the tutorial. Ignore any errors that might stem from previous unsuccessful runs of the experiments.

@dimkart dimkart changed the title First Draft of the Tutorials Add DisCoCirc tutorial on babi task Feb 17, 2025
@dimkart
Copy link
Contributor

dimkart commented Feb 17, 2025

@ouissal-moumou Are there two separate notebooks? Can we just merge everything into one? If not, we will need a main index file that joins the two parts.

@neiljdo FYI

@neiljdo
Copy link
Collaborator

neiljdo commented Mar 20, 2025

@dimkart it seems the two notebooks can be merged into one to improve the flow of the tutorial - the second notebook is just the training step + result visualization. Doing so also makes this tutorial similar to the existing ones.

Also, the tutorial might benefit from some refactoring - I can work on this incrementally.

@dimkart
Copy link
Contributor

dimkart commented Mar 20, 2025

@neiljdo Great, and if you think you can merge the two notebooks let's do this.

Copy link

@DNA386 DNA386 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall good start on the tutorials, but there's a few places that could do with simplification to make the tutorial clearer. Some general comments to keep in mind:

  • try to keep your explanatory sentences shorter. some are very verbose, which can make it harder to follow what you mean.
  • in general it is more 'pythonic' to use list/dict comprehensions where you can rather than for loops. (at least in my opinion) this will typically make your code easier to follow too. I've tried to suggest the simplifications in places I think it would help, but feel free to disagree!

@neiljdo neiljdo mentioned this pull request Jun 3, 2025
@neiljdo
Copy link
Collaborator

neiljdo commented Jun 4, 2025

Closing this as PR #63 now supersedes this.

@neiljdo neiljdo closed this Jun 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants