Skip to content

fix: More edges in InlineDFG#3072

Open
acl-cqc wants to merge 5 commits into
mainfrom
acl/inline_dfg_more_order
Open

fix: More edges in InlineDFG#3072
acl-cqc wants to merge 5 commits into
mainfrom
acl/inline_dfg_more_order

Conversation

@acl-cqc
Copy link
Copy Markdown
Contributor

@acl-cqc acl-cqc commented May 20, 2026

A corner case when inlining a DFG that's disconnected (no path from Input to Output, e.g. that just loads a constant) could lead to the chain/web of order edges going through the DFG being cut where the DFG was.

Fix: if there is no order path from Input to Output, then explicitly connect order-predecessors of the DFG to order-successors (we might use other criteria for the "if", but this seems a reasonable one).

@acl-cqc acl-cqc requested a review from a team as a code owner May 20, 2026 16:53
@acl-cqc acl-cqc requested a review from mark-koch May 20, 2026 16:53
@codecov
Copy link
Copy Markdown

codecov Bot commented May 20, 2026

Codecov Report

❌ Patch coverage is 95.31250% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 81.22%. Comparing base (abf286a) to head (7b34136).

Files with missing lines Patch % Lines
hugr-core/src/hugr/patch/inline_dfg.rs 95.31% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3072      +/-   ##
==========================================
+ Coverage   81.20%   81.22%   +0.01%     
==========================================
  Files         242      242              
  Lines       45622    45686      +64     
  Branches    39378    39442      +64     
==========================================
+ Hits        37048    37109      +61     
- Misses       6586     6589       +3     
  Partials     1988     1988              
Flag Coverage Δ
python 88.88% <ø> (ø)
rust 80.01% <95.31%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant