Skip to content

fix: Publish parametrisation check for types#3066

Merged
maximilianruesch merged 1 commit into
mainfrom
mr/fix/publish-parametrized
May 19, 2026
Merged

fix: Publish parametrisation check for types#3066
maximilianruesch merged 1 commit into
mainfrom
mr/fix/publish-parametrized

Conversation

@maximilianruesch
Copy link
Copy Markdown
Collaborator

It seems that in #3056, I forgot to make this function public, and I need it to be public for work in Quantinuum/tket2#1609.

@maximilianruesch maximilianruesch requested a review from a team as a code owner May 19, 2026 16:17
@maximilianruesch maximilianruesch self-assigned this May 19, 2026
Copy link
Copy Markdown
Collaborator

@aborgna-q aborgna-q left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

-.-'

@codecov
Copy link
Copy Markdown

codecov Bot commented May 19, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 81.20%. Comparing base (28ab1a7) to head (7e09779).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3066   +/-   ##
=======================================
  Coverage   81.20%   81.20%           
=======================================
  Files         242      242           
  Lines       45622    45622           
  Branches    39378    39378           
=======================================
  Hits        37048    37048           
  Misses       6586     6586           
  Partials     1988     1988           
Flag Coverage Δ
python 88.88% <ø> (ø)
rust 79.98% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@maximilianruesch maximilianruesch added this pull request to the merge queue May 19, 2026
@hugrbot
Copy link
Copy Markdown
Collaborator

hugrbot commented May 19, 2026

This PR contains breaking changes to the public Rust API.
Please deprecate the old API instead (if possible), or mark the PR with a ! to indicate a breaking change.

cargo-semver-checks summary
    Building hugr v0.27.1 (current)
     Built [  35.711s] (current)
   Parsing hugr v0.27.1 (current)
    Parsed [   0.004s] (current)
  Building hugr v0.27.1 (baseline)
     Built [  34.313s] (baseline)
   Parsing hugr v0.27.1 (baseline)
    Parsed [   0.004s] (baseline)
  Checking hugr v0.27.1 -> v0.27.1 (assume minor change)
   Checked [   0.011s] 196 checks: 196 pass, 56 skip
   Summary no semver update required
  Finished [  71.352s] hugr
  Building hugr-cli v0.27.1 (current)
     Built [  28.371s] (current)
   Parsing hugr-cli v0.27.1 (current)
    Parsed [   0.006s] (current)
  Building hugr-cli v0.27.1 (baseline)
     Built [  27.980s] (baseline)
   Parsing hugr-cli v0.27.1 (baseline)
    Parsed [   0.006s] (baseline)
  Checking hugr-cli v0.27.1 -> v0.27.1 (assume minor change)
   Checked [   0.015s] 196 checks: 196 pass, 56 skip
   Summary no semver update required
  Finished [  58.351s] hugr-cli
  Building hugr-core v0.27.1 (current)
     Built [  24.613s] (current)
   Parsing hugr-core v0.27.1 (current)
    Parsed [   0.086s] (current)
  Building hugr-core v0.27.1 (baseline)
     Built [  24.314s] (baseline)
   Parsing hugr-core v0.27.1 (baseline)
    Parsed [   0.079s] (baseline)
  Checking hugr-core v0.27.1 -> v0.27.1 (assume minor change)
   Checked [   0.212s] 196 checks: 195 pass, 1 fail, 0 warn, 56 skip

--- failure enum_variant_added: enum variant added on exhaustive enum ---

Description:
A publicly-visible enum without #[non_exhaustive] has a new variant.
      ref: https://doc.rust-lang.org/cargo/reference/semver.html#enum-variant-new
     impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.47.0/src/lints/enum_variant_added.ron

Failed in:
variant NodeLabel:MetadataValues in /home/runner/work/hugr/hugr/PR_BRANCH/hugr-core/src/hugr/views/render.rs:185

   Summary semver requires new major version: 1 major and 0 minor checks failed
  Finished [  50.366s] hugr-core
  Building hugr-llvm v0.27.1 (current)
     Built [  28.922s] (current)
   Parsing hugr-llvm v0.27.1 (current)
    Parsed [   0.013s] (current)
  Building hugr-llvm v0.27.1 (baseline)
     Built [  29.090s] (baseline)
   Parsing hugr-llvm v0.27.1 (baseline)
    Parsed [   0.012s] (baseline)
  Checking hugr-llvm v0.27.1 -> v0.27.1 (assume minor change)
   Checked [   0.039s] 196 checks: 195 pass, 1 fail, 0 warn, 56 skip

--- failure method_parameter_count_changed: pub method parameter count changed ---

Description:
A publicly-visible method now takes a different number of parameters, not counting the receiver (self) parameter.
      ref: https://doc.rust-lang.org/cargo/reference/semver.html#fn-change-arity
     impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.47.0/src/lints/method_parameter_count_changed.ron

Failed in:
hugr_llvm::emit::test::Emission::emit_hugr takes 2 parameters in /home/runner/work/hugr/hugr/BASELINE_BRANCH/hugr-llvm/src/emit/test.rs:39, but now takes 3 parameters in /home/runner/work/hugr/hugr/PR_BRANCH/hugr-llvm/src/emit/test.rs:43
hugr_llvm::emit::EmitHugr::emit_module takes 1 parameters in /home/runner/work/hugr/hugr/BASELINE_BRANCH/hugr-llvm/src/emit.rs:324, but now takes 3 parameters in /home/runner/work/hugr/hugr/PR_BRANCH/hugr-llvm/src/emit.rs:363

   Summary semver requires new major version: 1 major and 0 minor checks failed
  Finished [  59.105s] hugr-llvm
  Building hugr-model v0.27.1 (current)
     Built [  10.515s] (current)
   Parsing hugr-model v0.27.1 (current)
    Parsed [   0.017s] (current)
  Building hugr-model v0.27.1 (baseline)
     Built [  10.698s] (baseline)
   Parsing hugr-model v0.27.1 (baseline)
    Parsed [   0.016s] (baseline)
  Checking hugr-model v0.27.1 -> v0.27.1 (assume minor change)
   Checked [   0.029s] 196 checks: 196 pass, 56 skip
   Summary no semver update required
  Finished [  22.087s] hugr-model
  Building hugr-persistent v0.6.1 (current)
     Built [  21.500s] (current)
   Parsing hugr-persistent v0.6.1 (current)
    Parsed [   0.008s] (current)
  Building hugr-persistent v0.6.1 (baseline)
     Built [  21.562s] (baseline)
   Parsing hugr-persistent v0.6.1 (baseline)
    Parsed [   0.007s] (baseline)
  Checking hugr-persistent v0.6.1 -> v0.6.1 (assume minor change)
   Checked [   0.012s] 196 checks: 196 pass, 56 skip
   Summary no semver update required
  Finished [  44.250s] hugr-persistent

Merged via the queue into main with commit 1b37fff May 19, 2026
30 of 31 checks passed
@maximilianruesch maximilianruesch deleted the mr/fix/publish-parametrized branch May 19, 2026 16:30
@hugrbot hugrbot mentioned this pull request May 19, 2026
@maximilianruesch maximilianruesch restored the mr/fix/publish-parametrized branch May 20, 2026 08:25
@maximilianruesch maximilianruesch deleted the mr/fix/publish-parametrized branch May 20, 2026 08:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants