Skip to content

feat(hugrv2)!: Rename TermTypeError -> TermKindError#3053

Merged
acl-cqc merged 4 commits into
acl/rename_type_kindfrom
acl/term_kind_error
May 12, 2026
Merged

feat(hugrv2)!: Rename TermTypeError -> TermKindError#3053
acl-cqc merged 4 commits into
acl/rename_type_kindfrom
acl/term_kind_error

Conversation

@acl-cqc
Copy link
Copy Markdown
Contributor

@acl-cqc acl-cqc commented May 11, 2026

Continuing from #3019 where I suggested renaming the "TypeMismatch" variant of this enum to "KindMismatch". Well it seems like we should do that, but in which case we should do a bit more too....

Will merge this into #3019 before merging that into main.

@acl-cqc acl-cqc requested a review from a team as a code owner May 11, 2026 14:37
@acl-cqc acl-cqc requested review from croyzor and removed request for a team May 11, 2026 14:37
@hugrbot
Copy link
Copy Markdown
Collaborator

hugrbot commented May 11, 2026

Hey there and thank you for opening this pull request! 👋

It looks like your proposed title indicates a breaking change. If that's the case,
please make sure to include a "BREAKING CHANGE:" footer in the body of the pull request
describing the breaking change and any migration instructions.

@acl-cqc acl-cqc changed the title Acl/term kind error feat(hugrv2)!: Rename TermTypeError -> TermKindError May 11, 2026
@codecov
Copy link
Copy Markdown

codecov Bot commented May 11, 2026

Codecov Report

❌ Patch coverage is 78.57143% with 9 lines in your changes missing coverage. Please review.
✅ Project coverage is 81.09%. Comparing base (98e1cea) to head (c041c5b).

Files with missing lines Patch % Lines
...ore/src/std_extensions/collections/static_array.rs 0.00% 3 Missing ⚠️
hugr-core/src/types.rs 71.42% 2 Missing ⚠️
hugr-core/src/extension/simple_op.rs 0.00% 1 Missing ⚠️
hugr-core/src/import.rs 0.00% 1 Missing ⚠️
hugr-core/src/types/check.rs 0.00% 1 Missing ⚠️
hugr-core/src/types/type_param.rs 90.00% 1 Missing ⚠️
Additional details and impacted files
@@                  Coverage Diff                  @@
##           acl/rename_type_kind    #3053   +/-   ##
=====================================================
  Coverage                 81.09%   81.09%           
=====================================================
  Files                       241      241           
  Lines                     45050    45050           
  Branches                  38818    38818           
=====================================================
  Hits                      36532    36532           
  Misses                     6542     6542           
  Partials                   1976     1976           
Flag Coverage Δ
python 88.89% <ø> (ø)
rust 79.83% <78.57%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@acl-cqc acl-cqc merged commit bbb4015 into acl/rename_type_kind May 12, 2026
27 of 31 checks passed
@acl-cqc acl-cqc deleted the acl/term_kind_error branch May 12, 2026 17:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants