feat(hugr-py): Allow providing visibility when building function definitions#2862
Closed
maximilianruesch wants to merge 5 commits intomainfrom
Closed
feat(hugr-py): Allow providing visibility when building function definitions#2862maximilianruesch wants to merge 5 commits intomainfrom
maximilianruesch wants to merge 5 commits intomainfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2862 +/- ##
=======================================
Coverage 83.80% 83.80%
=======================================
Files 267 267
Lines 53728 53728
Branches 47793 47793
=======================================
Hits 45029 45029
Misses 6284 6284
Partials 2415 2415
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
Author
|
It is indeed the same / #2772 covers more (it allows to configure visibility of declarations, which I removed from this PR because private declarations are not really useful for me). Closing this one, since it is redundant now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allows providing a visibility when constructing function definitions, for purposes of allowing annotation of these in
guppylang.Related to Quantinuum/guppylang#1482.