Skip to content

feat(hugr-py): Allow providing visibility when building function definitions#2862

Closed
maximilianruesch wants to merge 5 commits intomainfrom
mr/feat/allow-visibility-in-bindings
Closed

feat(hugr-py): Allow providing visibility when building function definitions#2862
maximilianruesch wants to merge 5 commits intomainfrom
mr/feat/allow-visibility-in-bindings

Conversation

@maximilianruesch
Copy link
Copy Markdown
Contributor

@maximilianruesch maximilianruesch commented Feb 6, 2026

Allows providing a visibility when constructing function definitions, for purposes of allowing annotation of these in guppylang.

Related to Quantinuum/guppylang#1482.

@codecov
Copy link
Copy Markdown

codecov Bot commented Feb 6, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 83.80%. Comparing base (7890e2f) to head (6663248).
⚠️ Report is 10 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2862   +/-   ##
=======================================
  Coverage   83.80%   83.80%           
=======================================
  Files         267      267           
  Lines       53728    53728           
  Branches    47793    47793           
=======================================
  Hits        45029    45029           
  Misses       6284     6284           
  Partials     2415     2415           
Flag Coverage Δ
python 88.50% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@maximilianruesch maximilianruesch marked this pull request as ready for review February 23, 2026 13:48
@maximilianruesch maximilianruesch requested a review from a team as a code owner February 23, 2026 13:48
@maximilianruesch maximilianruesch changed the title feat(hugr-py): Allow providing visibility when building function definitions and declarations feat(hugr-py): Allow providing visibility when building function definitions Feb 23, 2026
Copy link
Copy Markdown
Contributor

@acl-cqc acl-cqc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks much like what I put in as #2772 - sorry for lack of fanfare but can you check?

@maximilianruesch
Copy link
Copy Markdown
Contributor Author

It is indeed the same / #2772 covers more (it allows to configure visibility of declarations, which I removed from this PR because private declarations are not really useful for me).

Closing this one, since it is redundant now.

@maximilianruesch maximilianruesch deleted the mr/feat/allow-visibility-in-bindings branch March 3, 2026 11:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants