Skip to content

docs: Improve SPAM documentation #198

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
daniel-mills-cqc wants to merge 1 commit into
base: main
Choose a base branch
from
Open

docs: Improve SPAM documentation #198

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 7 additions & 5 deletions qermit/spam/full_spam_correction.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,6 +59,8 @@ def task(
== qubit_subsets
):
return (wire, [], [])

print("qubit_subsets: ", qubit_subsets)

process_circuit = Circuit(
len([qb for subset in qubit_subsets for qb in subset])
Expand Down Expand Up @@ -179,7 +181,7 @@ def get_mid_circuit_measure_map(

def gen_get_bit_maps_task() -> MitTask:
"""
Returns a task that takes a list of circuits and returns the circuits, and a map betwen
Returns a task that takes a list of circuits and returns the circuits, and a map between
each circuit bit and the qubit it is measured on.
"""

Expand All @@ -193,12 +195,12 @@ def task(
"""
bq_maps = []
for c in circuit_shots:
qb_map = c[0].qubit_to_bit_map
# if condition met, implies that mid circuit measurement has ocurred and not accounted for
qb_map = c.Circuit.qubit_to_bit_map
# if condition met, implies that mid circuit measurement has occurred and not accounted for
# in this case, iterate through circuit commands to get Qubits for all Bits
if len(qb_map) != len(c[0].bits):
if len(qb_map) != len(c.Circuit.bits):
bq_maps.append(
(qb_map, get_mid_circuit_measure_map(c[0], set(qb_map.values())))
(qb_map, get_mid_circuit_measure_map(c.Circuit, set(qb_map.values())))
)
else:
# else, just invert map for later correction
Expand Down
4 changes: 3 additions & 1 deletion tests/full_spam_test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,8 @@
from pytket import Bit, Circuit, Qubit
from pytket.extensions.qiskit import AerBackend # type: ignore

from qermit import CircuitShots

from qermit.spam import ( # type: ignore
CorrectionMethod,
)
Expand Down Expand Up @@ -90,7 +92,7 @@ def test_gen_get_bit_maps_task():

c0 = Circuit(3).CX(0, 1).X(2).measure_all()
c1 = Circuit(2, 2).X(0).Measure(0, 0).X(1).SWAP(0, 1).Measure(0, 1)
wire = [(c0, 10), (c1, 50)]
wire = [CircuitShots(c0, 10), CircuitShots(c1, 50)]
res = task([wire])
assert len(res) == 2
assert res[0] == wire
Expand Down