Don't include unused inputs in ndonnx_schema when they are dropped by ndonnx.build#211
Merged
Merged
Conversation
Sam Gilmour (sgilm)
requested a review
from Christian Bourjau (cbourjau)
as a code owner
Christian Bourjau (cbourjau)
approved these changes
May 6, 2026
Collaborator
Christian Bourjau (cbourjau)
left a comment
Christian Bourjau (cbourjau)
left a comment
There was a problem hiding this comment.
Thanks a lot!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If indeed #210 is a bug, this PR adds a failing test and fixes it.
Makes sure that any inputs that are entirely dropped from the built graph with
ndx.build(..., drop_unused=True)do not appear in thendonnx_schema.Closes #210.