Fix corner-cases with ndonnx.{any,all,arange} and __setitem__#144
Merged
Conversation
Christian Bourjau (cbourjau)
force-pushed
the
issue-142a
branch
from
ae46f17 to
18bd9d9
Compare
Christian Bourjau (cbourjau)
force-pushed
the
issue-142a
branch
from
6de2d4b to
d44386f
Compare
Christian Bourjau (cbourjau)
force-pushed
the
issue-142a
branch
from
43bde39 to
64e4230
Compare
Christian Bourjau (cbourjau)
requested a review
from Aditya Goel (adityagoel4512)
as a code owner
Christian Bourjau (cbourjau)
requested a review
from Aditya Goel (adityagoel4512)
Christian Bourjau (cbourjau)
changed the title
Aditya Goel (adityagoel4512)
approved these changes
Jun 6, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes the corner cases discovered by #142 and some more.
This turned out to be one big annoying chore. There was one legitimate bug in
__setitem__where we failed to validate an invalid key. Everything else is just working around ... surprising ... quirks in the onnxruntime. I also started to add the test cases discovered by Hypothesis as explicit tests to the test suite.A follow-up to this PR can be found in the reorganize-ci branch which is based on this PR. It runs the extensive array-api test suite on this PR in the hope that we finally pass the scheduled runs without discovering a new issue.