fix: Sampling for List columns with min_length > 32 #248
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix List column sampling when min_length > 32
Summary
Fixed a bug where sampling would fail with
ValueError: low >= highfor List columns whenmin_length > 32andmax_lengthis not specified.Changes made:
dataframely/columns/list.py: UpdatedList._sample_uncheckedmethod to calculatedefault_max = max(32, min_len)ensuring the max parameter is always greater than min when max_length is not specifiedtests/column_types/test_list.py: Parametrized test covering min_length values of 0, 10, 33, and 100castimport and used it to properly type the result oflist.len().min()Test results:
Original prompt
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.