-
Notifications
You must be signed in to change notification settings - Fork 13
feat: Validate schema members against polars DataType usage #246
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add check for pl.DataType instances (e.g., pl.String()) - Add check for pl.DataType types (e.g., pl.String) - Add test cases for both scenarios - Tests pass and linting is clean Co-authored-by: borchero <22455425+borchero@users.noreply.github.com>
Remove redundant example from error message to make it clearer Co-authored-by: borchero <22455425+borchero@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix silent error in schema member validation
Validate schema members against polars DataType usage
Dec 17, 2025
borchero
reviewed
Dec 17, 2025
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #246 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 53 53
Lines 3066 3070 +4
=========================================
+ Hits 3066 3070 +4 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Refactor the two separate checks for pl.DataType instance and type into a single conditional as requested by reviewer Co-authored-by: borchero <22455425+borchero@users.noreply.github.com>
jjurm
approved these changes
Dec 18, 2025
AndreasAlbertQC
approved these changes
Dec 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SchemaMeta.__new__to detect schema members that are instances ofpl.DataTypeSchemaMeta.__new__to detect schema members that are types (subclasses) ofpl.DataTypeOriginal prompt
pl.DataTypeortype[pl.DataType]#245✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.