Add inv and derivativeinv to some utility functions#225
Open
Add inv and derivativeinv to some utility functions#225
Conversation
Codecov Report
@@ Coverage Diff @@
## master #225 +/- ##
==========================================
+ Coverage 95.85% 95.89% +0.04%
==========================================
Files 25 25
Lines 1061 1073 +12
==========================================
+ Hits 1017 1029 +12
Misses 44 44
Continue to review full report at Codecov.
|
Member
|
General comment -- I think we should consider edge cases in both the implementation and the testing. For example, what happens at |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds methods for
u^{-1}anddu^{-1}for utility functions where it can be computed by hand.I have some tests that make sure
u(u^{-1})returns what we expect (also have them fordu(du^{-1})), but it wouldn't hurt to have someone glance at the equations to make sure I didn't do anything stupid.