Revert "Implement circuit component and vm (#66)"#167
Merged
Conversation
This reverts commit 60de9c8. PR #66 (squash-merged) is causing repeated merge-conflict churn on main. Reverting it here so main is stable again; the full change set remains on branch david/42-circuit-component and is re-opened as a fresh PR so the useful pieces can be re-introduced via targeted cherry-picks. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
There was a problem hiding this comment.
Pull request overview
Reverts the squash-merged changes from PR #66 to restore main to the pre-#66 codebase state, removing the previously introduced circuit/VM (ppvm-vihaco), .sst/CLI tooling, and related APIs/tests to reduce ongoing merge-conflict churn.
Changes:
- Removes the
ppvm-vihacobackend/VM and theppvm-cli.ssttooling (crates, fixtures, and documentation references). - Removes the
RotXY/r(...)rotation surface across Rust traits/tableau/pauli-sum and the Python bindings/tests that were added alongside it. - Updates workspace membership/CI/docs pointers to reflect the removal and keeps pre-commit tooling running via
mise exec.
Reviewed changes
Copilot reviewed 61 out of 64 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| skills/ppvm-usage/SKILL.md | Removes .sst/CLI/vihaco guidance and example pointers from the usage skill. |
| prek.toml | Runs hawkeye via mise exec -- for consistent tool resolution. |
| ppvm-python/test/test_basics.py | Removes PauliSum r(...) gate tests. |
| ppvm-python/test/generalized_tableau/test_basics.py | Removes GeneralizedTableau r(...) gate tests. |
| ppvm-python/src/ppvm/mixins.py | Removes public Python r(...) rotation mixins. |
| crates/vihaco-circuit-isa/src/lib.rs | Deletes the circuit ISA crate implementation. |
| crates/vihaco-circuit-isa/Cargo.toml | Deletes the circuit ISA crate manifest. |
| crates/ppvm-vihaco/tests/tableau_ry_z_trace.sst | Deletes .sst fixture. |
| crates/ppvm-vihaco/tests/tableau_ghz_xxx_trace.sst | Deletes .sst fixture. |
| crates/ppvm-vihaco/tests/tableau_bell_trace.sst | Deletes .sst fixture. |
| crates/ppvm-vihaco/tests/sst_fixtures.rs | Deletes end-to-end .sst fixture test suite. |
| crates/ppvm-vihaco/tests/rotxy.sst | Deletes .sst fixture. |
| crates/ppvm-vihaco/tests/paulisum_trotter_truncate.sst | Deletes .sst fixture. |
| crates/ppvm-vihaco/tests/paulisum_ry_z_trace.sst | Deletes .sst fixture. |
| crates/ppvm-vihaco/tests/paulisum_multi_term_trace.sst | Deletes .sst fixture. |
| crates/ppvm-vihaco/tests/paulisum_measure_error.sst | Deletes .sst fixture. |
| crates/ppvm-vihaco/tests/paulisum_ghz_xxx_trace.sst | Deletes .sst fixture. |
| crates/ppvm-vihaco/tests/paulisum_bell_trace.sst | Deletes .sst fixture. |
| crates/ppvm-vihaco/tests/lossy_paulisum_loss_trace.sst | Deletes .sst fixture. |
| crates/ppvm-vihaco/tests/hello_circuit.sst | Deletes .sst fixture. |
| crates/ppvm-vihaco/tests/function_call.sst | Deletes .sst fixture. |
| crates/ppvm-vihaco/tests/function_call_ret.sst | Deletes .sst fixture. |
| crates/ppvm-vihaco/tests/function_call_branch_both.sst | Deletes .sst fixture. |
| crates/ppvm-vihaco/tests/branch_on_outcome.sst | Deletes .sst fixture. |
| crates/ppvm-vihaco/tests/branch_on_outcome_x.sst | Deletes .sst fixture. |
| crates/ppvm-vihaco/tests/bell.sst | Deletes .sst fixture. |
| crates/ppvm-vihaco/src/syntax.rs | Deletes .sst syntax/parser/resolver implementation. |
| crates/ppvm-vihaco/src/shots.rs | Deletes multi-shot runner (serial/parallel) implementation. |
| crates/ppvm-vihaco/src/observable.rs | Deletes Pauli-sum observable header parser. |
| crates/ppvm-vihaco/src/measurements.rs | Deletes measurement/trace observer/effect plumbing for VM. |
| crates/ppvm-vihaco/src/lib.rs | Deletes ppvm-vihaco public API surface. |
| crates/ppvm-vihaco/src/component.rs | Deletes circuit executor/component implementation. |
| crates/ppvm-vihaco/src/bytecode.rs | Deletes .ssb bytecode container format implementation. |
| crates/ppvm-vihaco/Cargo.toml | Deletes the ppvm-vihaco crate manifest. |
| crates/ppvm-traits/src/traits/mod.rs | Stops re-exporting RotXY. |
| crates/ppvm-traits/src/traits/branch/rot1.rs | Removes the RotXY trait definition. |
| crates/ppvm-traits/src/traits/branch/mod.rs | Removes RotXY from branch module exports. |
| crates/ppvm-tableau/src/lib.rs | Removes the expectation/trace module export. |
| crates/ppvm-tableau/src/gates/rot1.rs | Removes RotXY implementation and its tests. |
| crates/ppvm-tableau/src/expectation.rs | Deletes tableau expectation/trace implementation and tests. |
| crates/ppvm-tableau/src/data.rs | Removes/reset-related helpers and reverts coefficient relabel parallelism guard. |
| crates/ppvm-tableau/Cargo.toml | Drops ppvm-pauli-word dependency (no longer needed after expectation removal). |
| crates/ppvm-runtime/src/traits/branch/rot1.rs | Deletes runtime RotationOne/RotXY trait file introduced by #66. |
| crates/ppvm-python-native/src/interface.rs | Removes r(...) binding for PauliSum interface. |
| crates/ppvm-python-native/src/interface_tableau.rs | Removes r(...) binding for tableau interface. |
| crates/ppvm-python-native/ppvm_python_native.pyi | Deletes the generated Python stub file added by #66. |
| crates/ppvm-pauli-sum/src/sum/rot1.rs | Removes RotXY implementation and its tests. |
| crates/ppvm-cli/src/main.rs | Deletes the ppvm CLI entrypoint. |
| crates/ppvm-cli/src/commands.rs | Deletes CLI command implementations/tests. |
| crates/ppvm-cli/README.md | Deletes CLI documentation. |
| crates/ppvm-cli/examples/simple_loop.sst | Deletes CLI example program. |
| crates/ppvm-cli/examples/loop_feedforward.sst | Deletes CLI example program. |
| crates/ppvm-cli/examples/loop_feedforward.pseudo | Deletes CLI example pseudocode. |
| crates/ppvm-cli/examples/heisenberg_zz.sst | Deletes CLI example program. |
| crates/ppvm-cli/examples/ghz.sst | Deletes CLI example program. |
| crates/ppvm-cli/examples/bit_flip_correction.sst | Deletes CLI example program. |
| crates/ppvm-cli/Cargo.toml | Deletes the CLI crate manifest. |
| Cargo.toml | Removes ppvm-cli/vihaco-circuit-isa workspace members and ppvm-vihaco from the workspace. |
| AGENTS.md | Removes .sst/CLI references from the agent-facing usage pointer. |
| .gitignore | Removes debug/ ignore entry added alongside CLI debugging. |
| .github/workflows/ci.yml | Updates wasm build exclusions now that ppvm-cli is no longer part of the workspace. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts #66.
PR #66 was squash-merged into
main(commit60de9c8b) but is causing repeated merge-conflict churn onmain. This PR reverts that squash commit, restoringmainto exactly its pre-#66 state (verified: reverted tree is identical to2570637b, the commit immediately before the merge).No work is lost:
david/42-circuit-component.Merge this first, then cherry-pick from the companion PR.
🤖 Generated with Claude Code