Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR implements AOD (Acousto-Optic Deflector) tracking analysis functionality by adding a new tracking dialect and associated infrastructure. The changes enable system state tracking through quantum operations and provide analysis capabilities for AOD positioning.
Key changes:
- Adds a new
trackingdialect with system state management operations - Implements AOD analysis framework with lattice-based state tracking
- Refactors TraceInterpreter constructor to use keyword-only architecture specification
- Moves ActionTracer from taskgen to its own module for better separation of concerns
Reviewed Changes
Copilot reviewed 22 out of 22 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| src/bloqade/shuttle/dialects/tracking/* | New tracking dialect with types, statements, and AOD analysis |
| src/bloqade/shuttle/passes/path2tracking.py | Pass to convert path operations to tracking operations |
| src/bloqade/shuttle/analysis/aod/* | AOD analysis framework with lattice-based state tracking |
| src/bloqade/shuttle/codegen/taskgen.py | Refactored TraceInterpreter constructor and moved ActionTracer |
| src/bloqade/shuttle/dialects/action/trace.py | New dedicated module for ActionTracer |
| src/bloqade/shuttle/arch.py | Added AOD tone limits and made arch_spec keyword-only |
| src/bloqade/shuttle/dialects/measure/* | Updated to use squin dialect's MeasurementResult |
| test/unit/codegen/test_taskgen.py | Updated TraceInterpreter calls to use keyword arguments |
| test/codegen/test_taskgen.py | Updated TraceInterpreter calls to use keyword arguments |
Comments suppressed due to low confidence (1)
src/bloqade/shuttle/arch.py:124
- The hash method doesn't include the new max_x_tones and max_y_tones fields, which could lead to incorrect hash behavior when these values differ between instances.
def __hash__(self):
return hash(
(
self.layout,
frozenset(self.float_constants.items()),
frozenset(self.int_constants.items()),
)
)
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
|
|
||
| # path = _interp.get_const_value(Path, stmt.path) | ||
| # for action in path.path: | ||
| # match |
There was a problem hiding this comment.
Incomplete match statement syntax. This line ends abruptly and will cause a SyntaxError.
Suggested change
| # match | |
| # match action: | |
| # # TODO: implement cases for action | |
| # pass |
Contributor
|
Codecov Report❌ Patch coverage is 📢 Thoughts on this report? Let us know! |
Contributor
☂️ Python Coverage
Overall Coverage
New Files
Modified Files
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.