-
Notifications
You must be signed in to change notification settings - Fork 158
Add slurm plugin docs #3944
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Add slurm plugin docs #3944
Conversation
docs/guides/slurm-hpc-ux.mdx
Outdated
|
|
||
| ##### User scope | ||
| Execution lanes are not exposed to the HPC administrator or user directly. | ||
| Instead, mid term, there can be two different modes that HPC users can specify: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| Instead, mid term, there can be two different modes that HPC users can specify: | |
| Instead, mid-term, there can be two different modes that HPC users can specify: |
I'm not sure what mid-term refers to here (and once previously in this file) - does it mean "currently, but will probably change, because it's under development"?
Co-authored-by: abbycross <across@us.ibm.com>
ohtanim
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@kaelynj I have finished to review with a couple of change requests. Could you please incorporate my comments ? Thanks,
|
|
||
| # Quantum resource management interface (QRMI) | ||
|
|
||
| The Quantum resource management interface (QRMI) is a vendor-agnostic library for high-performance compute (HPC) systems to control state, run tasks, and monitor the behavior of quantum computational resources. It acts as a thin middleware layer that abstracts away the complexities associated with controlling quantum resources through a set of simple APIs. Written in Rust, this interface also exposes Python and C APIs for ease of integration into nearly any computational environment. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"to control state, run tasks, and monitor"
would be
"to access, control, and monitor"
| from qiskit import QuantumCircuit | ||
| # using an IBM QRMI flavor: | ||
| from qrmi.primitives import QRMIService | ||
| from qrmi.primitives.ibm import SamplerV2, get_target |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
get_target should be changed to get_backend.
(Our git repo will be also changed soon)
| qrmi = resources[0] | ||
|
|
||
| # Generate transpiler target from backend configuration & properties and transpile | ||
| target = get_target(qrmi) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This line should be changed to:
backend = get_backend(qrmi)
Our repo will also be updated soon.
| target = get_target(qrmi) | ||
| pm = generate_preset_pass_manager( | ||
| optimization_level=1, | ||
| target=target, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
target=target,
should be changed to:
backend=backend,
(Our repo will also be updated soon.)
| print(f">>> Job ID: {job.job_id()}") | ||
|
|
||
| result = job.result() | ||
| print(f">>> {result}") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This line should be changed to:
if job.done():
pub_result = result[0]
print(f"Counts for the 'meas' output register: {pub_result.data.meas.get_counts()}")
elif job.cancelled():
print("Cancelled")
elif job.errored():
print(qrmi.task_logs(job.job_id()))
(Our git repo will be updated soon)
Closes #3781