Skip to content

[FEATURE] add support for gitlab and gogs repositories#47

Merged
akbargumbira merged 1 commit intoQGIS-Contribution:developfrom
slarosa:develop
Nov 5, 2017
Merged

[FEATURE] add support for gitlab and gogs repositories#47
akbargumbira merged 1 commit intoQGIS-Contribution:developfrom
slarosa:develop

Conversation

@slarosa
Copy link
Copy Markdown
Contributor

@slarosa slarosa commented Nov 2, 2017

This will also support git.osgeo.org/gogs repositories.

@slarosa slarosa changed the title [FEATURE] add support for gitlab repository [FEATURE] add support for gitlab and gogs repository Nov 3, 2017
@slarosa slarosa changed the title [FEATURE] add support for gitlab and gogs repository [FEATURE] add support for gitlab and gogs repositories Nov 3, 2017
@slarosa
Copy link
Copy Markdown
Contributor Author

slarosa commented Nov 3, 2017

hi @akbargumbira , please could you take a look at this PR.
I see the travis failure, but I can't understand why it is failing!

Thanks.

@akbargumbira
Copy link
Copy Markdown
Collaborator

hi @slarosa, thanks! I just had a quick look on the PR, for the gitlab_handler I will merge it this weekend and perhaps release it after fixing the unittest :)

One thing is that, can you remove the GogsHandler commits to the giturlparse module? I prefer to have these changes being pushed to the upstream repository (https://github.com/FriendCode/giturlparse.py), so that they can have benefit of this and it won't be hard to update changes from upstream to this repository later

Cheers

@slarosa
Copy link
Copy Markdown
Contributor Author

slarosa commented Nov 3, 2017

@akbargumbira wrote:

hi @slarosa, thanks! I just had a quick look on the PR, for the gitlab_handler I will merge it this weekend and perhaps release it after fixing the unittest :)

great!

One thing is that, can you remove the GogsHandler commits to the giturlparse module? I prefer to have these changes being pushed to the upstream repository (https://github.com/FriendCode/giturlparse.py), so that they can have benefit of this and it won't be hard to update changes from upstream to this repository later

sure, but that package is not maintained anymore, it doesn't?
I saw that it is a third party package so I thought to update it from this repo.
We (QGIS Italian group) created a gogs repository [0] to share some resources and GOGS handler is necessary for this reason.
No problem to issue a new PR to the upstream repository of giturlparse, but I fear it will not be merged quickly :-(

Thanks.

[0] - https://git.osgeo.org/gogs/qgisitalia/QGIS-Italia-Risorse

@slarosa slarosa force-pushed the develop branch 3 times, most recently from 359e812 to 804e530 Compare November 3, 2017 11:56
@akbargumbira
Copy link
Copy Markdown
Collaborator

sure, but that package is not maintained anymore, it doesn't?
I saw that it is a third party package so I thought to update it from this repo.
We (QGIS Italian group) created a gogs repository [0] to share some resources and GOGS handler is necessary for this reason.
No problem to issue a new PR to the upstream repository of giturlparse, but I fear it will not be merged quickly :-(

Alright. Let's not remove those commits, but let's make a PR to their repo (it's up to them to merge it/not)

@slarosa slarosa force-pushed the develop branch 8 times, most recently from e1825d8 to 4c5df41 Compare November 3, 2017 15:47
@coveralls
Copy link
Copy Markdown

Coverage Status

Coverage decreased (-1.3%) to 51.561% when pulling 4c5df41 on slarosa:develop into 7ade644 on akbargumbira:develop.

@slarosa slarosa force-pushed the develop branch 2 times, most recently from 90f81c8 to 5de5fb6 Compare November 3, 2017 15:55
@coveralls
Copy link
Copy Markdown

Coverage Status

Coverage decreased (-1.4%) to 51.498% when pulling 5de5fb6 on slarosa:develop into 7ade644 on akbargumbira:develop.

@slarosa slarosa force-pushed the develop branch 2 times, most recently from 302fa5d to e7a89c5 Compare November 3, 2017 16:03
@coveralls
Copy link
Copy Markdown

Coverage Status

Coverage decreased (-1.2%) to 51.623% when pulling e7a89c5 on slarosa:develop into 7ade644 on akbargumbira:develop.

@coveralls
Copy link
Copy Markdown

Coverage Status

Coverage decreased (-1.4%) to 51.498% when pulling f496d67 on slarosa:develop into 7ade644 on akbargumbira:develop.

@slarosa slarosa force-pushed the develop branch 2 times, most recently from eea66f1 to ca9c86b Compare November 3, 2017 16:23
@slarosa
Copy link
Copy Markdown
Contributor Author

slarosa commented Nov 3, 2017

@akbargumbira sorry for the noise, but I have been trying to understand if the travis failure depends from my changes. It seems be uncorrelated with the changes of this PR.
Also, I just issued a PR on FriendCode/giturlparse.py#16

Thanks.

@akbargumbira akbargumbira merged commit 8347f14 into QGIS-Contribution:develop Nov 5, 2017
@slarosa
Copy link
Copy Markdown
Contributor Author

slarosa commented Nov 5, 2017

Thanks @akbargumbira .

@akbargumbira
Copy link
Copy Markdown
Collaborator

@slarosa I just released a new version with this support. Thanks for your work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants