Add aria labels to icon-only controls#11
Open
Martinnn674 wants to merge 2 commits into
Open
Conversation
307c94d to
45ae064
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #8.
Summary
aria-labelvalues to icon-only controls in the settings modal, rail, channel list, and channel header.Verification
npx.cmd tsx --test tests/icon-button-labels.test.tsnpx.cmd eslint components/channel-header.tsx components/rail.tsx components/channel-list.tsx components/settings-modal.tsx tests/icon-button-labels.test.ts tests/migration.test.tsnpx.cmd tsc --noEmitnpm.cmd run test:migrationnpm.cmd run testNotes