Skip to content

feat: Rename and reorder YXFanLevel enum members #787

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
allenporter merged 4 commits into from
Mar 16, 2026
Merged

feat: Rename and reorder YXFanLevel enum members #787

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
b14e926
chore: Rename and reorder `YXFanLevel` enum members
allenporter Mar 16, 2026
f7473a9
chore: Fix MAX_PLUS enum value
allenporter Mar 16, 2026
cddf881
docs: Add docstring and alias comments to the YXFanLevel enum.
allenporter Mar 16, 2026
833b239
chore: fix lint.
allenporter Mar 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions roborock/data/b01_q10/b01_q10_code_mappings.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -120,12 +120,12 @@ class B01_Q10_DP(RoborockModeEnum):

class YXFanLevel(RoborockModeEnum):
UNKNOWN = "unknown", -1
CLOSE = "close", 0
OFF = "off", 0
QUIET = "quiet", 1
NORMAL = "normal", 2
STRONG = "strong", 3
BALANCED = "balanced", 2
TURBO = "turbo", 3
MAX = "max", 4
SUPER = "super", 8
MAX_PLUS = "max_plus", 8


class YXWaterLevel(RoborockModeEnum):
Expand Down
2 changes: 1 addition & 1 deletion tests/devices/traits/b01/q10/test_status.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -139,7 +139,7 @@ async def test_status_trait_refresh(
# Verify trait attributes are updated
assert q10_api.status.battery == 100
assert q10_api.status.status == YXDeviceState.CHARGING_STATE
assert q10_api.status.fan_level == YXFanLevel.NORMAL
assert q10_api.status.fan_level == YXFanLevel.BALANCED


def test_status_trait_update_listener(q10_api: Q10PropertiesApi) -> None:
Expand Down
2 changes: 1 addition & 1 deletion tests/devices/traits/b01/q10/test_vacuum.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ def vacuumm_fixture(q10_api: Q10PropertiesApi) -> VacuumTrait:
(lambda x: x.return_to_dock(), {"203": {}}),
(lambda x: x.empty_dustbin(), {"203": 2}),
(lambda x: x.set_clean_mode(YXCleanType.BOTH_WORK), {"137": 1}),
(lambda x: x.set_fan_level(YXFanLevel.NORMAL), {"123": 2}),
(lambda x: x.set_fan_level(YXFanLevel.BALANCED), {"123": 2}),
],
)
async def test_vacuum_commands(
Expand Down
Loading