Skip to content

fix: Properly shutdown the context in the CLI #710

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
allenporter merged 3 commits into from
Dec 29, 2025
Merged

fix: Properly shutdown the context in the CLI #710

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
7d25d9d
fix: Properly shutdown the context in the CLI
allenporter Dec 27, 2025
9120d35
chore: improve error handling for session loop
allenporter Dec 27, 2025
9ff90a4
chore: Fix exception catching
allenporter Dec 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion roborock/cli.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,7 +91,13 @@ def wrapper(*args, **kwargs):
context: RoborockContext = ctx.obj

async def run():
return await func(*args, **kwargs)
try:
await func(*args, **kwargs)
except Exception:
_LOGGER.exception("Uncaught exception in command")
click.echo(f"Error: {sys.exc_info()[1]}", err=True)
Comment thread
allenporter marked this conversation as resolved.
Outdated
Comment thread
allenporter marked this conversation as resolved.
Outdated
finally:
await context.cleanup()
Comment thread
allenporter marked this conversation as resolved.
Outdated

if context.is_session_mode():
# Session mode - run in the persistent loop
Expand Down