Skip to content

Add 2 new states for ZeoState in zeo_code_mappings #689

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Lash-L merged 5 commits into from
Jan 18, 2026
Merged

Add 2 new states for ZeoState in zeo_code_mappings #689

Changes from 3 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
42b0f2c
Add 2 new states for ZeoState in zeo_code_mappings
NOisi-x Dec 18, 2025
b41b6d6
Rename Aftercare to aftercare in zeo_code_mappings
NOisi-x Dec 18, 2025
c6085e3
Fix order of aftercare and waitingforaftercare values
NOisi-x Dec 18, 2025
6b7e25f
Fix typo in waitingforaftercare constant name
NOisi-x Dec 23, 2025
5480998
chore: lint
Lash-L Jan 18, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion roborock/data/zeo/zeo_code_mappings.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,8 @@ class ZeoState(RoborockEnum):
cooling = 8
under_delay_start = 9
done = 10

aftercare = 12
waitingforaftercare = 13
Copy link
Copy Markdown
Contributor

@allenporter allenporter Dec 22, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should the value have underscores between words similar to under_delay_start?

(I assuming this is parsed by number and not string name)

Copy link
Copy Markdown
Contributor Author

@NOisi-x NOisi-x Dec 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is indeed parsed by number and the string name is defined, so it can be changed if there are any formatting requirements for the string name.

Copy link
Copy Markdown
Contributor

@allenporter allenporter Dec 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK follow the existing pattern please where underscores are used between words

Copy link
Copy Markdown
Contributor Author

@NOisi-x NOisi-x Dec 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done. Thank you.


Comment thread
Lash-L marked this conversation as resolved.
class ZeoProgram(RoborockEnum):
standard = 1
Expand Down
Loading