Skip to content

Yahoo cheerio migration, dead code cleanup, enriched share endpoint#57

Merged
Pyronewbic merged 1 commit into
mainfrom
dev
May 12, 2026
Merged

Yahoo cheerio migration, dead code cleanup, enriched share endpoint#57
Pyronewbic merged 1 commit into
mainfrom
dev

Conversation

@Pyronewbic
Copy link
Copy Markdown
Owner

Summary

  • Yahoo Auctions: Playwright → fetch+cheerio (~10x faster, no browser dep)
  • Removed Redis import from api.js, updateCardField from card-identity.js
  • Share endpoint: correct card name/rarity from demo query, per-source price breakdown, set name stripped from card name

Breaking changes

None — Yahoo Auctions returns same data shape, share endpoint adds fields

Demo data

  • Sample data still works (?demo=true)
  • No new fields missing from demo cards

Manual verification

  • /api/card/share/m4/114-083 shows "Mega Greninja ex" not "Ninja Spinner"

Yahoo Auctions scraper migrated from Playwright to fetch+cheerio,
matching magi.js pattern. ~10x faster, no browser dependency.

Removed: Redis cache import from api.js (unused), updateCardField
from card-identity.js (never called). Health endpoint reports redis
as "not configured" instead of checking connection.
@Pyronewbic Pyronewbic merged commit 1b07ab8 into main May 12, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant