Skip to content

Fix share endpoint demo lookup #55

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Pyronewbic merged 1 commit into from
May 12, 2026
+13 −4
Merged

Fix share endpoint demo lookup #55

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 13 additions & 4 deletions api.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -651,16 +651,25 @@ app.get("/api/card", apiAuthMiddleware, async (req, res) => {
app.get("/api/card/share/:setCode/:number", async (req, res) => {
const cardId = `${req.params.setCode}/${req.params.number}`;
const searchQuery = resolveCardIdToQuery(cardId);
const numberQuery = req.params.number.replace("-", "/");

function findDemo() {
let d = getDemoSearchResult(searchQuery, {});
if (d._demo) return d;
d = getDemoSearchResult(numberQuery, {});
if (d._demo) return d;
return getDemoSearchResult(cardId.replace("-", "/"), {});
}

try {
const demoResult = findDemo();
const [card, search, priceData] = await Promise.all([
findCardByQuery(searchQuery).catch(() => null),
(async () => {
const demo = getDemoSearchResult(searchQuery, {});
return demo._demo ? demo : null;
return demoResult._demo ? demoResult : null;
})(),
(async () => {
const demo = getDemoSearchResult(searchQuery, {});
const sold = (demo.sold || []).filter(s => s.soldDate && s.price);
const sold = (demoResult.sold || []).filter(s => s.soldDate && s.price);
const history = sold.map(s => ({ price: s.price, recordedAt: s.soldDate }));
const prices = history.map(h => h.price);
return {
Expand Down