Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion CHANGELOG.rst
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ News
3.0.5 (unreleased)
------------------

- Nothing changed yet.
- Strip ``<option>`` text.


3.0.4 (2025-02-03)
Expand Down
4 changes: 3 additions & 1 deletion tests/html/form_inputs.html
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,9 @@
<select name="select">
<option value="value1">Value 1</option>
<option value="value2" selected>Value 2</option>
<option value="value3">Value 3</option>
<option value="value3">
Value 3
</option>
</select>
<input type="file" name="file" />
<input type="unknown" name="unknown" />
Expand Down
6 changes: 6 additions & 0 deletions tests/test_forms.py
Original file line number Diff line number Diff line change
Expand Up @@ -63,6 +63,12 @@ def test_force_select(self):

def test_form_select(self):
form = self.callFUT()

self.assertEqual(form['select'].options, [
('value1', False, 'Value 1'),
('value2', True, 'Value 2'),
('value3', False, 'Value 3')
])
form.select('select', 'value1')

self.assertEqual(
Expand Down
2 changes: 1 addition & 1 deletion webtest/forms.py
Original file line number Diff line number Diff line change
Expand Up @@ -501,7 +501,7 @@ def _form_elt_filter(tag):
field.options.append(
(option.attrs.get('value', option.text),
'selected' in option.attrs,
option.text))
option.text.strip()))

self.field_order = field_order
self.fields = fields
Expand Down