[SecondSpectrum] Meta Data Expansion #485
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
I've rewritten a small part of the SecondSpectrum tracking data parser to hopefully accomodate more meta data formats.
It works with the old data, but it now also works with a broader set of meta data.
I've introduced
find_json_key()a function to search metadata a bit more flexibly. For example, some times "pitchLength" exists in the root, while other times it might exist in "Stadium"/"PitchLength".find_json_keywill search for a value pitch length (disregarding capital letters) and then return the first found value.I think an approach like this might be a way forward to allow for way more flexible metadata parsing.
In total my approach does:
self.__periods_from_raw_dataEitherway, it should be a lot more flexible already.