Improve the sequence state builder #484
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lode-mgp
changed the title
Contributor
|
@lode-mgp Can you merge this one with master (or give me edit access to the branch, such that I can do it myself)? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR, I address the issues discussed in issue 385. I made adjustments only to the existing
SequenceStateBuilderand did not yet start implementing a newPossessionStateBuilder.PICK_UPorCLAIM, as well as take-ons and successful interceptions, can now start a new sequence.Duels at the end of a sequence are handled correctly
When a sequence ends with a duel between two players, the lost duel is part of the old sequence and the winning duel is part of the new sequence.
Off-ball and generic events don't get a sequence id
Additionally, I ensured that sequence IDs increment consistently without skipping numbers.