Skip to content

Add MISSING state to Dataset #56

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
koenvo merged 1 commit into from
Dec 11, 2025
Merged

Add MISSING state to Dataset #56

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions ingestify/domain/models/dataset/dataset_state.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@ class DatasetState(str, Enum):
SCHEDULED = "SCHEDULED"
PARTIAL = "PARTIAL"
COMPLETE = "COMPLETE"
MISSING = "MISSING"

@property
def is_complete(self):
Expand Down
19 changes: 14 additions & 5 deletions ingestify/tests/test_pagination.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,9 +91,14 @@ def test_dataset_state_filter(config_file):
now = datetime.now(pytz.utc)

# Create datasets with different states
states = [DatasetState.COMPLETE, DatasetState.PARTIAL, DatasetState.SCHEDULED]
for i in range(9): # 3 datasets per state
state = states[i % 3]
states = [
DatasetState.COMPLETE,
DatasetState.PARTIAL,
DatasetState.SCHEDULED,
DatasetState.MISSING,
]
for i in range(12): # 3 datasets per state
state = states[i % 4]
dataset = Dataset(
bucket=bucket,
dataset_id=f"state-test-{i}",
Expand Down Expand Up @@ -124,9 +129,13 @@ def test_dataset_state_filter(config_file):
# Test filtering by multiple states using a list of enums
mixed_datasets = store.get_dataset_collection(
dataset_type="state-test",
dataset_state=[DatasetState.COMPLETE, DatasetState.SCHEDULED],
dataset_state=[
DatasetState.COMPLETE,
DatasetState.SCHEDULED,
DatasetState.MISSING,
],
)
assert len(mixed_datasets) == 6
assert len(mixed_datasets) == 9

# Test filtering by multiple states using a list of strings
mixed_datasets_strings = store.get_dataset_collection(
Expand Down