You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Fixes overly aggressive DC link simplification in simplify_network (literal edge case example for new UK/Shetland HVDC and multi-terminal setup)
Updates supernodes so only true chain nodes (degree 2, also applied to DC) are collapsed. Preserves DC junction buses/multi-terminals (degree 3+) to avoid dropping branches in topologies like Shetland to onshore branching links.
Original base network topology
Before fix remove_stubs: true
remove_stubs: false
After fix remove_stubs: true
remove_stubs: false
Checklist
Required:
Changes are tested locally and behave as expected.
Code and workflow changes are documented.
A release note entry is added to doc/release_notes.rst.
I had to add a new key, named it allow_ac_dc_mix for now to make this decision transparent/user configurable. Specifically, now that more DC buses "survive", it can happen that AC and DC buses in the same region (depending on clustering mode) are to be clustered. The question is, do you keep them separate (maintaining individual bus carriers) or allow DC buses to be clustered with AC buses (in this case all bus carriers become AC).
"Visually" this looks the same, however, the underlying subnetworks and topology, number of lines and links change.
For example, using config/test/config.clusters.yaml (administrative clustering)
allow_ac_dc_mix: false → 54 buses, 10 subnetworks (AC and DC kept separate)
Open question, what to set as default. I believe the closest to replicate old behaviour is to allow mixing of AC and DC, but the technically more correct way would be to set allow_ac_dc_mix: false, as you also could have congestion between the AC and DC buses. Any thoughts? @fneum@brynpickering, maybe @martacki (given your clustering expertise :))
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes open-energy-transition#275
@brynpickering @euronion
Same bug present in PyPSA-Eur upstream
Changes proposed in this Pull Request
simplify_network(literal edge case example for new UK/Shetland HVDC and multi-terminal setup)Original base network topology

Before fix

remove_stubs: trueremove_stubs: falseAfter fix

remove_stubs: trueremove_stubs: falseChecklist
Required:
doc/release_notes.rst.